Fix exception types for channels to ensure transparency & reporting #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizarov
force-pushed
the
channel-exceptions
branch
from
59ee2a5 to
03f2424
Compare
* ReceiveChannel.cancel always closes channel with CancellationException, so sending or receiving from a cancelled channel produces the corresponding CancellationException. * Cancelling produce builder has similar effect, but an more specific instance of JobCancellationException is created. * This ensure that produce/consumeEach pair is transparent with respect to cancellation and can be used to build "identity" transformation of the flow (the corresponding test is added). * ClosedSendChannelException is now a subclass of IllegalStateException, so that trying to send to a channel that was closed normally is reported as program error and is not eaten (test is added). Fixes #957 Fixes #1128
elizarov
force-pushed
the
channel-exceptions
branch
from
03f2424 to
58a5585
Compare
* Documentation improved
* Better exception message
* Simplified flowOn implementation
* Avoid exception instantiation on happy path in zip
qwwdfsad
approved these changes
Apr 30, 2019
zach-klippenstein
added a commit
to square/workflow
that referenced
this pull request
Jun 13, 2019
- Breakage in `CoroutineWorkflow` was caused by Kotlin/kotlinx.coroutines#1158. - Breakage in `ReactorAsWorkflowIntegrationTest` was probably caused by Kotlin/kotlinx.coroutines#1239.
zach-klippenstein
added a commit
to square/workflow
that referenced
this pull request
Jun 13, 2019
- Some things that were `@FlowPreview` have been graduated to `@ExperimentalCoroutinesApi`. - Breakage in `CoroutineWorkflow` was caused by Kotlin/kotlinx.coroutines#1158. - Breakage in `ReactorAsWorkflowIntegrationTest` was probably caused by Kotlin/kotlinx.coroutines#1239.
zach-klippenstein
added a commit
to square/workflow
that referenced
this pull request
Jun 26, 2019
- Some things that were `@FlowPreview` have been graduated to `@ExperimentalCoroutinesApi`. - Breakage in `CoroutineWorkflow` was caused by Kotlin/kotlinx.coroutines#1158. - Breakage in `ReactorAsWorkflowIntegrationTest` was probably caused by Kotlin/kotlinx.coroutines#1239.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so sending or receiving from a cancelled channel produces the
corresponding CancellationException.
instance of JobCancellationException is created.
to cancellation and can be used to build "identity" transformation
of the flow (the corresponding test is added).
so that trying to send to a channel that was closed normally is
reported as program error and is not eaten (test is added).
Fixes #957
Fixes #1128