Upgrade coroutines dep to 1.3.0-M1. #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrjr
approved these changes
Jun 13, 2019
| @@ -372,6 +375,7 @@ class ReactorAsWorkflowIntegrationTest { | |||
| assertFalse(resultSub.isCompleted) | |||
|
|
|||
| workflow.sendEvent("foo") | |||
| assertEquals(SecondState("foo"), stateSub.poll()) | |||
There was a problem hiding this comment.
Is this line for added coverage, or did the poll() call actually fix something?
There was a problem hiding this comment.
Conflated channels now hang onto their last value even after they're closed, so we have to pull it out first now.
| @@ -328,7 +327,7 @@ inline fun <reified T> ReceiveChannel<T>.asWorker( | |||
| * This **SHOULD NOT** be used in production code. | |||
| */ | |||
| @VeryExperimentalWorkflow | |||
| @FlowPreview | |||
| @ExperimentalCoroutinesApi | |||
kirillzh
approved these changes
Jun 21, 2019
- Some things that were `@FlowPreview` have been graduated to `@ExperimentalCoroutinesApi`. - Breakage in `CoroutineWorkflow` was caused by Kotlin/kotlinx.coroutines#1158. - Breakage in `ReactorAsWorkflowIntegrationTest` was probably caused by Kotlin/kotlinx.coroutines#1239.
|
1.3.0-M2 was just released, adding a commit to this PR to bump again. |
zach-klippenstein
force-pushed
the
zachklipp/coroutines-1.3.0-M1
branch
from
68ec830 to
02fe265
Compare
|
Still LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@FlowPreviewhave been graduated to@ExperimentalCoroutinesApi.CoroutineWorkflowwas caused by Fix exception types for channels to ensure transparency & reporting Kotlin/kotlinx.coroutines#1158.ReactorAsWorkflowIntegrationTestwas probably caused by Adjust behavior of conflated channel to deliver last value Kotlin/kotlinx.coroutines#1239.