Deprecate unaryPlus for Json array builder in favor of add
.
#462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly because of #418
There are three ways for it:
unaryPlus
only forNumber
(and probably other primitives)JsonElement
.This PR implements 3), but I suggest considering 2) as a resolution, because using
add
everywhere seems verbose and overhead-ish to me (see diff ofJsonArraySerializersTest
). However, this will lead to inconsistency:JsonElement
would be added viaunaryPlus
and other primitives viaadd
. WDYT, @qwwdfsad ?