Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework JSON DSL #794

Merged
merged 2 commits into from
Apr 13, 2020
Merged

Rework JSON DSL #794

merged 2 commits into from
Apr 13, 2020

Conversation

qwwdfsad
Copy link
Collaborator

@qwwdfsad qwwdfsad commented Apr 8, 2020

Fixes #418
Fixes #627

@qwwdfsad
Rework JSON DSL
0595041 
Fixes #418
Fixes #627
@qwwdfsad
Mention content escaping in JsonLiteral.
ed2b779 
After investigation, it seems like non-escaped content does not cause any troubles when used by kotlinx.serialization. The only harmful behaviour may be when a user serializes JsonElement by hand expecting it to be fully-compliant (-> escaped). Added a note to clarify it

Addresses #773
@qwwdfsad qwwdfsad marked this pull request as ready for review April 8, 2020 13:10
@altavir
Copy link

altavir commented Apr 8, 2020

I completely agree with decision to deprecate "pretty" DSL, espcially to infix. It is a source of a lot of errors. In my project I've replaced to by put infix, and it works much better. Also it is possible to use following syntax:

infix fun String.put(builderAction: JsonObjectBuilder.() -> Unit) = addJson(this,builderAction)

It allows to write:

json{
  "child" put {
    "subChild" put "fff
  }
}

@sandwwraith
Copy link
Member

sandwwraith commented Apr 10, 2020 •
edited
Loading

Changes are fine. WDYT of adding jsonOf function and making JsonObjectBuilder implement mutable map?

@sandwwraith sandwwraith mentioned this pull request Apr 13, 2020
Closed
@qwwdfsad qwwdfsad merged commit e58f884 into dev Apr 13, 2020
@qwwdfsad qwwdfsad deleted the json-dsl branch April 13, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandwwraith sandwwraith Awaiting requested review from sandwwraith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qwwdfsad @altavir @sandwwraith