Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Defining GetBoundingBox in Tree class. Plus adding documentation #11730

Merged
merged 4 commits into from
Oct 30, 2023
Merged

[Core] Defining GetBoundingBox in Tree class. Plus adding documentation #11730

merged 4 commits into from
Oct 30, 2023

Conversation

loumalouomega
Copy link
Member

@loumalouomega loumalouomega commented Oct 27, 2023 •
edited
Loading

📝 Description

This PR makes several changes to the Tree class in kratos/spatial_containers/tree.h to enhance its functionality and clarity. It includes:

  • Defining GetBoundingBox method in Tree class
  • Defining SizeType, IndexType, and CoordinateType, ... as aliases with using.
  • Adding documentation for member functions: ExistPoint, SearchNearestPoint, SearchInRadius, and SearchInBox.
  • Updating comments and documentation for better code understanding in general.
  • Minor code formatting improvements.

Also extending BoundingBox class documentation.

🆕 Changelog

@loumalouomega loumalouomega added Enhancement Cleanup Kratos Core Documentation FastPR This Pr is simple and / or has been already tested and the revision should be fast labels Oct 27, 2023
@loumalouomega loumalouomega requested a review from a team as a code owner October 27, 2023 14:13
@loumalouomega loumalouomega mentioned this pull request Oct 27, 2023
Open
@loumalouomega
Copy link
Member Author

@roigcarlo ?

@loumalouomega loumalouomega merged commit 93d76b3 into master Oct 30, 2023
10 of 11 checks passed
@loumalouomega loumalouomega deleted the core/tree-getbb-extra-doc branch October 30, 2023 14:42
@loumalouomega loumalouomega mentioned this pull request Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roigcarlo roigcarlo roigcarlo approved these changes

Assignees
No one assigned
Labels
Cleanup Documentation Enhancement FastPR This Pr is simple and / or has been already tested and the revision should be fast Kratos Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loumalouomega @roigcarlo