Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Defining bounding box and ObjectType in DynamicBins #11741

Merged
merged 5 commits into from
Nov 7, 2023

Conversation

loumalouomega
Copy link
Member

@loumalouomega loumalouomega commented Oct 31, 2023

📝 Description

Basically what has been done for Tree in #11730 and #11737 (plus #11739) but for DynamicBins.

  • Defining GetBoundingBox method in DynamicBins class
  • Defining SizeType, IndexType, and CoordinateType, ... as aliases with using.
  • Adding documentation for member functions: ExistPoint, SearchNearestPoint, SearchInRadius, and SearchInBox.
  • Updating comments and documentation for better code understanding in general.
  • Minor code formatting improvements.
  • Adding GetObjectType and define ObjectType in Tree. The ObjectType is taken from PointType when this is defined, otherwise void is defined. An auxiliary static method is defined in order to determine when ObjectType is defined.

🆕 Changelog

@loumalouomega loumalouomega added Kratos Core Documentation FastPR This Pr is simple and / or has been already tested and the revision should be fast Transition Inconsistent Refactor When code is moved or rewrote keeping the same behavior labels Oct 31, 2023
@loumalouomega loumalouomega requested a review from a team as a code owner October 31, 2023 15:44
@loumalouomega
Copy link
Member Author

@roigcarlo

@loumalouomega
Copy link
Member Author

@roigcarlo

helloooooo

@roigcarlo
Copy link
Member

helloooooo

Hi

@loumalouomega
Copy link
Member Author

helloooooo

Hi

🤗

kratos/spatial_containers/bins_dynamic.h Outdated Show resolved Hide resolved
kratos/spatial_containers/bins_dynamic.h Outdated Show resolved Hide resolved
kratos/spatial_containers/bins_dynamic.h Outdated Show resolved Hide resolved
kratos/spatial_containers/bins_dynamic.h Show resolved Hide resolved
@loumalouomega
Copy link
Member Author

@roigcarlo I tried to applied in the most possible way your comments, but due to the evil requirements of intrussive pointers, the node lacks some constructors and therefore I needed to slightly modify the constructor of the BB and preserve current behaviour for iterators constructor due to incompatibility of iterators classes.

Copy link
Member

@roigcarlo roigcarlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty

@roigcarlo
Copy link
Member

Btw the bounding box constructor can be fixed when we have traits some day in c++20, but probably is more flexible this way than it was before.

@loumalouomega loumalouomega merged commit a0ac2e9 into master Nov 7, 2023
10 of 11 checks passed
@loumalouomega loumalouomega deleted the core/consistent-dynamic-bins branch November 7, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation FastPR This Pr is simple and / or has been already tested and the revision should be fast Inconsistent Kratos Core Refactor When code is moved or rewrote keeping the same behavior Transition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants