-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Defining bounding box and ObjectType
in DynamicBins
#11741
Conversation
helloooooo |
Hi |
🤗 |
@roigcarlo I tried to applied in the most possible way your comments, but due to the evil requirements of intrussive pointers, the node lacks some constructors and therefore I needed to slightly modify the constructor of the BB and preserve current behaviour for iterators constructor due to incompatibility of iterators classes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ty
Btw the bounding box constructor can be fixed when we have traits some day in c++20, but probably is more flexible this way than it was before. |
📝 Description
Basically what has been done for
Tree
in #11730 and #11737 (plus #11739) but forDynamicBins
.GetBoundingBox
method inDynamicBins
classSizeType
,IndexType
, andCoordinateType
, ... as aliases withusing
.ExistPoint
,SearchNearestPoint
,SearchInRadius
, andSearchInBox
.GetObjectType
and defineObjectType
inTree
. TheObjectType
is taken fromPointType
when this is defined, otherwisevoid
is defined. An auxiliary static method is defined in order to determine whenObjectType
is defined.🆕 Changelog
ObjectType
inDynamicBins