codecov, fix: Fix the ignoring path regex pattern in codecov.yaml (#175) #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #221 +/- ##
==========================================
+ Coverage 52.40% 61.88% +9.47%
==========================================
Files 34 33 -1
Lines 3631 3112 -519
==========================================
+ Hits 1903 1926 +23
+ Misses 1532 994 -538
+ Partials 196 192 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
KevFan
reviewed
Aug 1, 2023
Yes, please! It is now ready! @KevFan |
| @@ -11,9 +11,10 @@ codecov: | |||
| comment: | |||
| layout: "header, diff, flags, components, files" | |||
|
|
|||
| # Find more at https://docs.codecov.com/docs/ignoring-paths | |||
| ignore: | |||
| - api/external/** # ignoring external vendor code | |||
There was a problem hiding this comment.
how is this line not affected?
There was a problem hiding this comment.
Sorry, DD. I was thinking about providing the direct link to the documentation, but now I am thinking that the link is prone to change. You are right, it was a useless comment 💯
alexsnaps
pushed a commit
that referenced
this pull request
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a fix to path ignoring regexp pattern in codecov.yaml.
The codecov.yaml was invalid because of missing double quotes in
"**/*.deepcopy.go"path.This PR is a part of #175, which just introduces a fix to a path for codecov.yaml so it can work correctly and be applied to the codecov configuration.
Read more at: https://docs.codecov.com/docs/ignoring-paths