Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codecov, fix: Fix the ignoring path regex pattern in codecov.yaml (#175) #221

Merged
merged 1 commit into from
Aug 1, 2023
Merged

codecov, fix: Fix the ignoring path regex pattern in codecov.yaml (#175) #221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/codecov.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,10 @@ codecov:
comment:
layout: "header, diff, flags, components, files"

# Find more at https://docs.codecov.com/docs/ignoring-paths
ignore:
- api/external/** # ignoring external vendor code
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is this line not affected?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, DD. I was thinking about providing the direct link to the documentation, but now I am thinking that the link is prone to change. You are right, it was a useless comment 💯

- **/*.deepcopy.go # ignore controller-gen generated code
- "**/*.deepcopy.go" # ignore controller-gen generated code

flag_management:
individual_flags:
Expand Down