Rlp v2 update main #225
Closed
Rlp v2 update main #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* docs: minor improvements * user-guide: fix authorization using k8s service account returning 403 instead of 200 Closes: #216
* gh workflow, codecov: Add codecov gh actions integration for unit & integration tests (#175) * codecov: Create and set up repository codecov.yaml config (#175) * makefile, refactor: Update Makefile for unit & integration tests (#175) - Added UNIT_DIRS and INTEGRATION_DIRS variables to specify directories test packages. - Modified the 'test-unit' and 'integration-test' recipes to run tests for the directories specified in UNIT_DIRS/INTEGRATION_DIRS and generate separate coverage reports for each directory. - Changed 'clean-cov' target to remove the 'coverage' directory instead of just 'cover.out'. These changes improve the test organization and ensure separate coverage reports for unit and integration tests. The 'clean-cov' target now removes the entire 'coverage' directory, cleaning up all coverage reports. * gitignore: Add folder with test coverages to .gitignore (#175) * codecov, refactor: Remove CODECOV_TOKEN because the repo is public * readme, codecov: Add codecov status badge to README (#175) * codecov: Add api/ to codecov report & exclude api/external (#175) * Makefile, refactor: Implemented recursive directory scanning (#175) kudos to @KevFan * codecov, refactor: Update .github/codecov.yaml api/v1beta1 component (#175) Co-authored-by: Kevin Fan <chfan@redhat.com> * codecov, refactor: Ignore controller-gen generated code (#175) Co-authored-by: Kevin Fan <chfan@redhat.com> * codecov: Add CODECOV_TOKEN despite repo being public to make CI/CD stable (#175) Read more at: https://community.codecov.com/t/upload-issues-unable-to-locate-build-via-github-actions-api/3954 Co-authored-by: Kevin Fan <chfan@redhat.com> --------- Co-authored-by: Kevin Fan <chfan@redhat.com>
Codecov Report
@@ Coverage Diff @@
## rlp-v2-base #225 +/- ##
==============================================
Coverage ? 63.02%
==============================================
Files ? 33
Lines ? 3224
Branches ? 0
==============================================
Hits ? 2032
Misses ? 1014
Partials ? 178
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
This PR probably will likely be superseded via a rebase instead - #230 |
|
Closing this since covered by #230. This PR was very useful nevertheless, to make sure we didn't miss anything in the rebase. Thanks @alexsnaps! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I'm repeating the pattern that's been used so far for this branch... but I'm not sure... and most importantly am very unsure how we best want to merge/make this
main?!