Skip to content

Commit

Permalink
[CH-197] Fix bug when c2r with const columns (#198)
Browse files Browse the repository at this point in the history
* close #197

* fix gtest build error
  • Loading branch information
taiyang-li authored Nov 18, 2022
1 parent 4fda39e commit 0fc2fae
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion utils/local-engine/Common/Logger.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ namespace local_engine
class Logger
{
public:
static void initConsoleLogger(const std::string & level);
static void initConsoleLogger(const std::string & level = "error");
static void initFileLogger(Poco::Util::AbstractConfiguration & config, const std::string & cmd_name);
};
}
Expand Down
4 changes: 3 additions & 1 deletion utils/local-engine/Parser/CHColumnToSparkRow.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -352,10 +352,12 @@ std::unique_ptr<SparkRowInfo> CHColumnToSparkRow::convertCHColumnToSparkRow(cons
{
const auto & col = block.getByPosition(col_idx);
int64_t field_offset = spark_row_info->getFieldOffset(col_idx);

ColumnWithTypeAndName col_not_const{col.column->convertToFullColumnIfConst(), col.type, col.name};
writeValue(
spark_row_info->getBufferAddress(),
field_offset,
col,
col_not_const,
col_idx,
spark_row_info->getNumRows(),
spark_row_info->getOffsets(),
Expand Down

0 comments on commit 0fc2fae

Please sign in to comment.