Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CH-197] Fix bug when c2r with const columns #198

Merged
merged 2 commits into from
Nov 18, 2022
Merged

[CH-197] Fix bug when c2r with const columns #198

merged 2 commits into from
Nov 18, 2022

Conversation

taiyang-li
Copy link

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

close #197

TODO

  • improve c2r performance when column is const

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@kyligence-git
Copy link
Collaborator

Can one of the admins verify this patch?

liuneng1994
liuneng1994 approved these changes Nov 18, 2022
View reviewed changes
Copy link
Collaborator

@liuneng1994 liuneng1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuneng1994 liuneng1994 merged commit 0fc2fae into Kyligence:clickhouse_backend Nov 18, 2022
@taiyang-li taiyang-li mentioned this pull request Nov 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuneng1994 liuneng1994 liuneng1994 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

c2r not right when column type is const
3 participants
@taiyang-li @kyligence-git @liuneng1994