Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CH-197] Fix bug when c2r with const columns #198

Merged
merged 2 commits into from
Nov 18, 2022
Merged

[CH-197] Fix bug when c2r with const columns #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfd9a7d
close https://github.com/Kyligence/ClickHouse/issues/197
taiyang-li Nov 17, 2022
9f634c1
fix gtest build error
taiyang-li Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion utils/local-engine/Common/Logger.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ namespace local_engine
class Logger
{
public:
static void initConsoleLogger(const std::string & level);
static void initConsoleLogger(const std::string & level = "error");
static void initFileLogger(Poco::Util::AbstractConfiguration & config, const std::string & cmd_name);
};
}
Expand Down
4 changes: 3 additions & 1 deletion utils/local-engine/Parser/CHColumnToSparkRow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,10 +352,12 @@ std::unique_ptr<SparkRowInfo> CHColumnToSparkRow::convertCHColumnToSparkRow(cons
{
const auto & col = block.getByPosition(col_idx);
int64_t field_offset = spark_row_info->getFieldOffset(col_idx);

ColumnWithTypeAndName col_not_const{col.column->convertToFullColumnIfConst(), col.type, col.name};
writeValue(
spark_row_info->getBufferAddress(),
field_offset,
col,
col_not_const,
col_idx,
spark_row_info->getNumRows(),
spark_row_info->getOffsets(),
Expand Down