[CH-358]Support json_tuple function #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
This was referenced Mar 15, 2023
|
test this please |
|
please add a gluten pr to add some ut for this function, thanks |
ok |
KevinyhZou
force-pushed
the
support_json_tuple
branch
from
e03a0be
to
54edb9b
Compare
ut added done in gluten pr: apache/incubator-gluten#1135. Thanks for your review @zzcclp |
|
test this please |
|
test this please with 1135 |
1 similar comment
|
test this please with 1135 |
liuneng1994
reviewed
Mar 31, 2023
| @@ -700,7 +700,7 @@ QueryPlanPtr SerializedPlanParser::parse(std::unique_ptr<substrait::Plan> plan) | |||
| ActionsDAGPtr actions_dag = std::make_shared<ActionsDAG>(blockToNameAndTypeList(query_plan->getCurrentDataStream().header)); | |||
| NamesWithAliases aliases; | |||
| auto cols = query_plan->getCurrentDataStream().header.getNamesAndTypesList(); | |||
| for (int i = 0; i < root_rel.root().names_size(); i++) | |||
| for (int i = 0; i < cols.getNames().size(); i++) | |||
KevinyhZou
force-pushed
the
support_json_tuple
branch
from
0453e1a
to
f6be52b
Compare
|
test this please with 1135 |
KevinyhZou
force-pushed
the
support_json_tuple
branch
from
bd04970
to
1ec3fef
Compare
|
test this please with 1135 |
|
@liuneng1994 cc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Implement json_tuple funtion by use JSONExtract function in ck, the releated issue: #358