[CH] Support json_tuple function #1135
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
| val expressTransformers = new Array[ExpressionTransformer](j.children.length) | ||
| for ( i <- j.children.indices) { | ||
| val t = replaceWithExpressionTransformer(j.children(i), attributeSeq) | ||
| expressTransformers(i) = t | ||
| } |
There was a problem hiding this comment.
change:
val children = j.children.map(child =>
replaceWithExpressionTransformer(child, attributeSeq))
|
please add some ut for this function, btw, it may need to support this function in ch backend? |
ok, I will add some ut. and I have support this function in ch backend in pr : ClickHouse/ClickHouse#47343 but I think this also can archive by JsonExtract function, i will open the pr to see whether it can be accpeted by clickhouse |
KevinyhZou
force-pushed
the
support_json_tuple_function
branch
from
699edc0
to
ad37fec
Compare
ut added done. @zzcclp |
zzcclp
changed the title
|
Can one of the admins verify this patch? |
KevinyhZou
force-pushed
the
support_json_tuple_function
branch
2 times, most recently
from
bf83190
to
0643fc6
Compare
KevinyhZou
force-pushed
the
support_json_tuple_function
branch
from
98ed105
to
09f31ee
Compare
|
Run Gluten Clickhouse CI |
KevinyhZou
force-pushed
the
support_json_tuple_function
branch
from
09f31ee
to
3690ec8
Compare
|
Run Gluten Clickhouse CI |
What changes were proposed in this pull request?
Support json_tuple funtion for spark in clickhouse backend， the related pr: Kyligence/ClickHouse#361
How was this patch tested?
test by unit test