Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chat list scroll bar too short for small number of chats. #3305

Closed
CertifiedJoon opened this issue Jun 6, 2023 · 1 comment · Fixed by #3319
Closed

Chat list scroll bar too short for small number of chats. #3305

CertifiedJoon opened this issue Jun 6, 2023 · 1 comment · Fixed by #3319
Assignees
@CertifiedJoon
Labels
bug Something isn't working good first issue Good issue for project newcomers UI/UX All website Components website

Comments

@CertifiedJoon
Copy link
Contributor

Below is UI when theres only a few chats (pop up menu is difficult to use)

image

Below is UI when there are a lot of chats (pop up is menu easy to use)

image

I believe the best way to solve this must be providing the chat list some default height, preferably flexible.
@olliestanley olliestanley added bug Something isn't working website good first issue Good issue for project newcomers UI/UX All website Components labels Jun 6, 2023
@CertifiedJoon
Copy link
Contributor Author

CertifiedJoon commented Jun 6, 2023 •
edited
Loading

I will work on this myself. Would that be okay?

@CertifiedJoon CertifiedJoon mentioned this issue Jun 7, 2023
Merged
@github-project-automation github-project-automation bot moved this to 📫 Triage in Open-Assistant Jun 9, 2023
@andreaskoepf andreaskoepf moved this from 📫 Triage to ⚙ In Progress in Open-Assistant Jun 9, 2023
AbdBarho pushed a commit that referenced this issue Jun 10, 2023
@CertifiedJoon
Modify: Default Height on Chat List (#3319)
d38f554 
Fixes: #3305 

/chat
I thought that it was intuitive to set height to of chat list to zero
when there is no chats on the list.
But, as soon as a chat has been added to the list, I have set the
default height.

/chat/{id}
I thought it is counter-intuitive to set default height to zero on this
page. I have set default height to hundered percent.

![ezgif
com-video-to-gif](https://github.com/LAION-AI/Open-Assistant/assets/61619422/66193754-36fb-42da-bc38-38e4abc7a86c)
@github-project-automation github-project-automation bot moved this from ⚙ In Progress to ✅ Done in Open-Assistant Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CertifiedJoon CertifiedJoon

Labels
bug Something isn't working good first issue Good issue for project newcomers UI/UX All website Components website
Projects
Open-Assistant
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modify: Default Height on Chat List CertifiedJoon/Open-Assistant
2 participants
@olliestanley @CertifiedJoon