Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify: Default Height on Chat List #3319

Merged
merged 1 commit into from
Jun 10, 2023
Merged

Conversation

CertifiedJoon
Copy link
Contributor

Fixes: #3305

/chat
I thought that it was intuitive to set height to of chat list to zero when there is no chats on the list.
But, as soon as a chat has been added to the list, I have set the default height.

/chat/{id}
I thought it is counter-intuitive to set default height to zero on this page. I have set default height to hundered percent.

ezgif com-video-to-gif

@CertifiedJoon CertifiedJoon marked this pull request as ready for review June 7, 2023 04:11
Copy link
Collaborator

@AbdBarho AbdBarho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AbdBarho AbdBarho merged commit d38f554 into LAION-AI:main Jun 10, 2023
@CertifiedJoon CertifiedJoon deleted the issue/3305 branch June 11, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chat list scroll bar too short for small number of chats.
3 participants