Disable unnecessary tautological compare for LLVM based Intel builds.

[rchen20]

Hi @white238, in RAJA when we turn on our "benchmark" builds, we're getting the following error when building with intel/2023.2.1-magic:

cd /usr/workspace/wsrzc/chen59/allraja/rajaarturobenchmark/raja_git_arturobenchmark/build_lc_toss4-icpx-2023.2.1-magic/blt/thirdparty_builtin/benchmark-1.8.0/src && /usr/tce/packages/intel/intel-2023.2.1-magic/bin/icpx -DBENCHMARK_STATIC_DEFINE -DHAVE_POSIX_REGEX -DHAVE_STD_REGEX -DHAVE_STEADY_CLOCK -DHAVE_TH
READ_SAFETY_ATTRIBUTES -I/usr/workspace/wsrzc/chen59/allraja/rajaarturobenchmark/raja_git_arturobenchmark/blt/thirdparty_builtin/benchmark-1.8.0/include -I/usr/workspace/wsrzc/chen59/allraja/rajaarturobenchmark/raja_git_arturobenchmark/blt/thirdparty_builtin/benchmark-1.8.0/src -Wall -Wextra       -Wall  -Wex
tra  -Wshadow  -Wfloat-equal  -Werror  -Wsuggest-override  -pedantic  -pedantic-errors  -Wshorten-64-to-32  -fstrict-aliasing  -Wno-deprecated-declarations  -Wno-deprecated  -Wstrict-aliasing  -Wthread-safety -O3 -march=native -finline-functions -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -pthread -
std=c++11 -MD -MT blt/thirdparty_builtin/benchmark-1.8.0/src/CMakeFiles/benchmark.dir/json_reporter.cc.o -MF CMakeFiles/benchmark.dir/json_reporter.cc.o.d -o CMakeFiles/benchmark.dir/json_reporter.cc.o -c /usr/workspace/wsrzc/chen59/allraja/rajaarturobenchmark/raja_git_arturobenchmark/blt/thirdparty_builtin/b
enchmark-1.8.0/src/json_reporter.cc                                                                                                                                                                                                                                                                                   
/usr/workspace/wsrzc/chen59/allraja/rajaarturobenchmark/raja_git_arturobenchmark/blt/thirdparty_builtin/benchmark-1.8.0/src/json_reporter.cc:92:7: error: explicit comparison with NaN in fast floating point mode [-Werror,-Wtautological-constant-compare]
  if (std::isnan(value))                                                                                                                                                                                                                                                                                              
      ^~~~~~~~~~~~~~~~~                                                                                                                                                                                                                                                                                               
/usr/workspace/wsrzc/chen59/allraja/rajaarturobenchmark/raja_git_arturobenchmark/blt/thirdparty_builtin/benchmark-1.8.0/src/json_reporter.cc:94:12: error: explicit comparison with infinity in fast floating point mode [-Werror,-Wtautological-constant-compare]                                                    
  else if (std::isinf(value))                                              
           ^~~~~~~~~~~~~~~~~                                                                                                                                                                                                                                                                                          
2 errors generated.

This sort of check seems rather unnecessary, so this PR turns it off for the newer Intel compilers. To reproduce, build with icpx on this RAJA branch LLNL/RAJA#1738.

[white238]

Thanks @rchen20 . Can you follow the pattern we have with patches so this does not get lost when we upgrade Google Benchmark?

Here is an example:

https://github.com/LLNL/blt/blob/develop/thirdparty_builtin/patches/gbenchmark-2023-05-10-remove-minimum-cmake.patch

[rchen20]

@white238 If I add a diff patch, would I just remove the changes I've made directly in the CMakeLists.txt?

[white238]

leave in the changes but add a patch so i know they should be there.. i can also push a change if you like.

[rchen20]

Added the patch file. Let me know if you need anything else.