Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning flag to silence warning promoted to error in IntelLLVM #708

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Add warning flag to silence warning promoted to error in IntelLLVM #708

merged 1 commit into from
Oct 21, 2024

Conversation

white238
Copy link
Member

User reported the following warning:

blt/thirdparty_builtin/googletest/googletest/src/gtest.cc:1639:8: warning: comparison with NaN always evaluates to false in fast floating point modes [-Wtautological-constant-compare]
  if (!(std::isnan)(val1) && !(std::isnan)(val2) && abs_error > 0 &&

This is similar to the previous PR #704

adayton1
adayton1 approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@adayton1 adayton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@white238 white238 merged commit 5468efd into develop Oct 21, 2024
8 checks passed
@white238 white238 deleted the bugfix/white238/nan_gtest branch October 21, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhornung67 rhornung67 rhornung67 approved these changes

@adayton1 adayton1 adayton1 approved these changes

@kennyweiss kennyweiss kennyweiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@white238 @kennyweiss @adayton1 @rhornung67