Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning flag to silence warning promoted to error in IntelLLVM #708

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Add warning flag to silence warning promoted to error in IntelLLVM #708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions RELEASE-NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ The project release numbers follow [Semantic Versioning](http://semver.org/spec/
- Guard HIP C smoketest against projects that don't enable C as a language in their projects.
- Changes benchmark custom target `run_benchmarks` to exclusively run benchmarks (not other general tests).
- Fix HIP smoketests to fail on HIP errors.
- Add `-Wno-tautological-compare` to GoogleTest/Mock/Benchmark for IntelLLVM compilers to silence
warning.

## [Version 0.6.2] - Release date 2024-03-15

Expand Down
2 changes: 2 additions & 0 deletions thirdparty_builtin/googletest/googletest/cmake/internal_utils.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,8 @@ macro(config_compiler_and_linker)
set(cxx_no_exception_flags "+noeh -DGTEST_HAS_EXCEPTIONS=0")
# RTTI can not be disabled in HP aCC compiler.
set(cxx_no_rtti_flags "")
elseif (CMAKE_CXX_COMPILER_ID STREQUAL "IntelLLVM")
set(cxx_base_flags "-Wno-tautological-compare")
endif()

# The pthreads library is available and allowed?
Expand Down
0 ...rk-2024_06_19-remove_gnuinstalldirs.patch → ...rk-2024-06-19-remove_gnuinstalldirs.patch
View file
Open in desktop
File renamed without changes.
0 ...st-2024_06_19-remove_gnuinstalldirs.patch → ...st-2024-06-19-remove_gnuinstalldirs.patch
View file
Open in desktop
File renamed without changes.
13 changes: 13 additions & 0 deletions thirdparty_builtin/patches/gtest-2024-10-18-suppress-tautological-intel-llvm.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
diff --git a/thirdparty_builtin/googletest/googletest/cmake/internal_utils.cmake b/thirdparty_builtin/googletest/googletest/cmake/internal_utils.cmake
index 6ddb794..0037804 100644
--- a/thirdparty_builtin/googletest/googletest/cmake/internal_utils.cmake
+++ b/thirdparty_builtin/googletest/googletest/cmake/internal_utils.cmake
@@ -134,6 +134,8 @@ macro(config_compiler_and_linker)
set(cxx_no_exception_flags "+noeh -DGTEST_HAS_EXCEPTIONS=0")
# RTTI can not be disabled in HP aCC compiler.
set(cxx_no_rtti_flags "")
+ elseif (CMAKE_CXX_COMPILER_ID STREQUAL "IntelLLVM")
+ set(cxx_base_flags "-Wno-tautological-compare")
endif()

# The pthreads library is available and allowed?