Add verification checks to Matrix inverse methods #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cval26
requested review from
ckendrick,
dylan-copeland,
chldkdtn and
siuwuncheung
dylan-copeland
approved these changes
Feb 2, 2024
ckendrick
approved these changes
Feb 2, 2024
siuwuncheung
approved these changes
Feb 2, 2024
andersonw1
pushed a commit
that referenced
this pull request
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds checks to the
Matrix.inversemethods, ensuring that the underlying Lapack routines have returned successfully. This is to prevent theinversemethods from silently returning incorrect data.