Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verification checks to Matrix inverse methods #265

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Add verification checks to Matrix inverse methods #265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions lib/linalg/Matrix.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -755,7 +755,11 @@ Matrix::inverse(
}
// Now call lapack to do the inversion.
dgetrf(&mtx_size, &mtx_size, result->d_mat, &mtx_size, ipiv, &info);
CAROM_VERIFY(info == 0);

dgetri(&mtx_size, result->d_mat, &mtx_size, ipiv, work, &lwork, &info);
CAROM_VERIFY(info == 0);

// Result now has the inverse in a column major representation. Put it
// into row major order.
for (int row = 0; row < mtx_size; ++row) {
Expand Down Expand Up @@ -798,7 +802,11 @@ Matrix::inverse(
}
// Now call lapack to do the inversion.
dgetrf(&mtx_size, &mtx_size, result.d_mat, &mtx_size, ipiv, &info);
CAROM_VERIFY(info == 0);

dgetri(&mtx_size, result.d_mat, &mtx_size, ipiv, work, &lwork, &info);
CAROM_VERIFY(info == 0);

// Result now has the inverse in a column major representation. Put it
// into row major order.
for (int row = 0; row < mtx_size; ++row) {
Expand Down Expand Up @@ -852,7 +860,11 @@ Matrix::inverse()
}
// Now call lapack to do the inversion.
dgetrf(&mtx_size, &mtx_size, d_mat, &mtx_size, ipiv, &info);
CAROM_VERIFY(info == 0);

dgetri(&mtx_size, d_mat, &mtx_size, ipiv, work, &lwork, &info);
CAROM_VERIFY(info == 0);

// This now has its inverse in a column major representation. Put it into
// row major representation.
for (int row = 0; row < mtx_size; ++row) {
Expand Down
Loading