Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting instrument name doesn't update the instrument window title #3009

Closed
zonkmachine opened this issue Aug 30, 2016 · 7 comments
Closed

Comments

@zonkmachine
Copy link
Member

zonkmachine commented Aug 30, 2016

renamebug

Since #2516 (@BaraMGB @Umcaruje) when you rename an instrument track the window title isn't updated properly.

In the picture I have renamed and then cloned an instrument two times. The window shows the name of the previous instrument on cloning but not the actual name.
Saving and reloading updates the window.

Edit: Spelling...

@BaraMGB
Copy link
Contributor

BaraMGB commented Aug 30, 2016

Same on controller windows. I look into it.
controllerrenamed

#2869 could be related.

@zonkmachine
Copy link
Member Author

zonkmachine commented Aug 31, 2016

#2869 could be related.

#2869 predates #3009. I don't know how much earlier it is though, I just checked one commit earlier than this one.

@zonkmachine
Copy link
Member Author

The main difference, as I see it, with the Controller Window Title behaviour is that it's present already in the 1.1.3 stable version.

@kamnxt
Copy link
Contributor

kamnxt commented Sep 4, 2016

Probably the same bug, but I found some more weird behavior.

  1. Open LMMS
  2. Rename the default TripleOsc to anything else
  3. Open the TripleOsc piano roll. The title should be correct.
  4. Rename the TripleOsc again, to anything else
  5. The piano roll's title doesn't change
  6. Create a new project, discarding the old one
  7. Open the piano roll. The title is still the same as it was before resetting!

@zonkmachine
Copy link
Member Author

Cool! I didn't notice the "extra stunt" that the Piano Roll window were doing but it's also fixed in #3012

@Umcaruje
Copy link
Member

I can't see that the bug @kamnxt mentioned is fixed by @BaraMGB's PR. Here's a gif:
gifrecord_2016-09-12_223603
The piano roll title only updates when you close and reopen the window.

@BaraMGB
Copy link
Contributor

BaraMGB commented Sep 12, 2016

I look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants