Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FX controllers overlap. #5032

Closed
Waulfree opened this issue Jun 13, 2019 · 4 comments
Closed

FX controllers overlap. #5032

Waulfree opened this issue Jun 13, 2019 · 4 comments
Assignees
Milestone

Comments

@Waulfree
Copy link

Waulfree commented Jun 13, 2019

See this: Untitledadasdasd223122312
Running win10 x64.
Using current lmms build (LMMS 1.2.0 rc8)

@zonkmachine zonkmachine added this to the 1.2.1 milestone Jun 13, 2019
@zonkmachine
Copy link
Member

Confirmed on lmms-1.2.0

@zonkmachine
Copy link
Member

This is leftover from #4482. I can fix it by going over the translations again and just removing the borked lines but maybe this is best handled on Transifex?

@zonkmachine zonkmachine self-assigned this Sep 12, 2019
@zonkmachine
Copy link
Member

zonkmachine commented Sep 14, 2019

In https://github.com/LMMS/lmms/pull/4482/files#diff-463bf9a84ee53b7ed35f64c1a918887bL1035-L1038 I just swapped the translation for the original.

--- a/data/locale/cs.ts
+++ b/data/locale/cs.ts
@@ -1034,7 +1034,7 @@ Máte-li zájem o překlad LMMS do jiného jazyka, nebo chcete-li vylepšit exis
     </message>
     <message>
         <source>FDBK</source>
-        <translation>ZP. VAZBA</translation>
+        <translation>FDBK</translation>
     </message>

I'm not sure whether this is a good way to do it. Some other options that gives the same result (on the user side) would be to:

Delete the translation:

-        <translation>ZP. VAZBA</translation>
+        <translation></translation>

Using the unfinished tag:

-        <translation>ZP. VAZBA</translation>
+        <translation type="unfinished"/>

Using the unfinished tag and some text/translation:

-        <translation>ZP. VAZBA</translation>
+        <translation type="unfinished">FIXME</translation>

I guess it doesn't matter that much if it's not merged back to Transifex but I don't know how we manage that side of the code. I'm thinking of going with <translation type="unfinished"/> when just deleting a translation that messes up the gui from now on. Any opinions on this @liushuyu ?

@zonkmachine
Copy link
Member

Closed in #5185

@zonkmachine zonkmachine modified the milestones: 1.2.2, 1.2.1 Oct 10, 2019
@PhysSong PhysSong added translation and removed i18n labels Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants