Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some formatting issues in translations #4482

Merged
merged 12 commits into from
Jul 31, 2018
Merged

Fix some formatting issues in translations #4482

merged 12 commits into from
Jul 31, 2018

Conversation

zonkmachine
Copy link
Member

@zonkmachine zonkmachine commented Jul 13, 2018 •
edited
Loading

Many translations seem to have been done without verifying against a compiled version of lmms. Maybe on the Transifex online editor. Especially the instrument pluggin editor and the native instruments/effects has many short terms and acronyms that must stay short or the layout will go south. I've gone through all translation files and reverted the worst cases. It may be that my machine won't show all problematic translations so a second pair of eyes would be nice here.
Fixes #4436
Fixes #4285

PS. I've also fixed up some general issues in the Swedish translation.

zonkmachine
zonkmachine commented Jul 14, 2018
View reviewed changes
data/locale/sv.ts
@@ -1454,7 +1454,7 @@ Right clicking will bring up a context menu where you can change the order in wh
<name>EnvelopeAndLfoView</name>
<message>
<source>DEL</source>
<translation>RADERA</translation>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤡

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not only a horribly wrong translation but it fundamentally borks the envelope knob layout. People are busy using the Transifex online interface and don't double check against a compiled real version of lmms.

zonkmachine
zonkmachine commented Jul 14, 2018
View reviewed changes
data/locale/sv.ts Outdated
@@ -1063,7 +1063,7 @@ If you&apos;re interested in translating LMMS in another language or want to imp
</message>
<message>
<source>FREQ</source>
<translation>FREKV.</translation>
<translation>FREK</translation>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either this or just revert to no translation here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted those to Freq/FREQ and some other Instrument plugin knob texts to the English original for now.

@zonkmachine
Copy link
Member Author

I'll leave this up one more day for review.

zonkmachine
zonkmachine commented Jul 15, 2018
View reviewed changes
data/locale/ja.ts Outdated
</TS>
Copy link
Member Author

@zonkmachine zonkmachine Jul 15, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the Japanese translators is working on a Windows machine... ...???

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't get what's going on here. I haven't found a setting for formatting in my editor (xed). I think only the Swedish translation didn't see this and I haven't touched it until now I think. Are these format fixes correct or should I revert them?

@zonkmachine zonkmachine mentioned this pull request Jul 17, 2018
Closed
@zonkmachine zonkmachine changed the title Fix pan knob formatting issue in Song-Editor Fix some formatting issues in translations Jul 17, 2018
@liushuyu
Copy link
Member

Please upload the translation fix to Transifex otherwise they will be overriden in next translation update

@PhysSong
Copy link
Member

Please upload the translation fix to Transifex otherwise they will be overriden in next translation update

It requires some permission. @zonkmachine can update Swedish, and @liushuyu can update German.
There are no Japanese translators in our development team, but I guess @Umcaruje can push it because he's the Team manager for all languages.

@liushuyu
Copy link
Member

liushuyu commented Jul 18, 2018 •
edited
Loading

It requires some permission. @zonkmachine can update Swedish, and @liushuyu can update German.

I am the administrator of the LMMS Transifex organization, I have write access to everything though.

@PhysSong
Copy link
Member

Then @liushuyu, could you update translation on Transifex once this PR gets merged?

@liushuyu
Copy link
Member

Then @liushuyu, could you update translation on Transifex once this PR gets merged?

Sure thing.

@zonkmachine
Copy link
Member Author

OK. I have reverted the translations that mess up formatting the most, especially in the Instrument Editor and the native pluggins, but have allowed some smaller issues as to keep this PR at a reasonable size.
This is now ready for review.

@zonkmachine zonkmachine requested a review from liushuyu July 24, 2018 14:33
@zonkmachine
Copy link
Member Author

Merge?

@zonkmachine
Copy link
Member Author

For reviewing this I don't think there's any point in going through all of it. The changes are pretty much the same across all languages. Reverting to original English as the translated line is too long and has a negative effect on the knob layout. Just comparing a couple of the languages should be enough and then the translators can take it from there.

@zonkmachine
Copy link
Member Author

I reverted some automatic formatting changes that my editor made. These edits may have been perfectly fine but I don't have time to look into it right now. Merging.

@zonkmachine zonkmachine merged commit b268abb into LMMS:stable-1.2 Jul 31, 2018
@zonkmachine zonkmachine deleted the translationfixes branch July 31, 2018 03:04
@PhysSong
Copy link
Member

PhysSong commented Aug 7, 2018

@liushuyu Could you please upload these changes to Transifex? It seems like you haven't.

@zonkmachine zonkmachine mentioned this pull request Jul 23, 2019
Closed
@zonkmachine zonkmachine mentioned this pull request Sep 14, 2019
Merged
zonkmachine added a commit that referenced this pull request Oct 10, 2019
@zonkmachine
Translation Fixes (Continuation of #4482) (#5185)
e321dff 
Fix some formatting issues with some translations. 

* Russian
* Polish
* Swedish
* Ukrainian
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
@zonkmachine
Fix some formatting issues in translations (LMMS#4482)
160fbf7 
* Swedish translation formatting and fixes
* German translation formatting
* Czech translation formatting
* Spanish translation formatting
* Farsi translation formatting
* French translation formatting
* Italian translation formatting
* Portuguese translation formatting
* Galician translation formatting
* Russian translation formatting
* Ukrainian translation formatting
* Japanese translation formatting
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
@zonkmachine
Translation Fixes (Continuation of LMMS#4482) (LMMS#5185)
ac4d14a 
Fix some formatting issues with some translations. 

* Russian
* Polish
* Swedish
* Ukrainian
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liushuyu liushuyu Awaiting requested review from liushuyu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panning knob in song-editor partially hidden in swedish Misaligned Knob in localised Delay Effect
3 participants
@zonkmachine @liushuyu @PhysSong