Some food data work for players #5

parlough · 2017-04-20T04:06:26Z

This is still work in progress, but I wouldn't mind some input as I continue on as I may be doing this completely wrong.

Cybermaxke · 2017-04-27T09:09:10Z

src/main/java/org/lanternpowered/server/entity/LanternLiving.java

@@ -45,6 +52,7 @@
 public class LanternLiving extends LanternEntity implements Living {

    private Vector3d headRotation = Vector3d.ZERO;
+    private long lastFoodTick = System.currentTimeMillis();


lastFoodTime is a better name

Cybermaxke · 2017-04-27T09:09:41Z

src/main/java/org/lanternpowered/server/entity/living/player/LanternPlayer.java

@@ -600,6 +597,9 @@ public void pulse() {
                offer(LanternKeys.ELYTRA_SPEED_BOOST, get(Keys.IS_SPRINTING).get());
            }
        }
+
+        getConnection().send(new MessagePlayOutPlayerHealthUpdate(health().get().floatValue(),


This should be moved to the PlayerEntityProtocol.

Cybermaxke · 2017-04-27T09:15:12Z

src/main/java/org/lanternpowered/server/entity/LanternLiving.java

+            return;
+        }
+        final Difficulty difficulty = getWorld().getDifficulty();
+


Try to reuse the Values more instead of looking them up multiple times and messing them up with normal get functions.
For example:

offer(Keys.FOOD_LEVEL, Math.max(get(Keys.FOOD_LEVEL).get() - 1, getValue(Keys.FOOD_LEVEL).get().getMinValue()));

to:

final MutableBoundedValue<Integer> foodLevel = getValue(Keys.FOOD_LEVEL).get(); offer(Keys.FOOD_LEVEL, Math.max(foodLevel.get() - 1, foodLevel.getMinValue()));

parlough · 2017-05-14T03:15:24Z

I'll try to finish this in a few days. Next weekend will bring more time for me.

Cybermaxke · 2017-06-25T08:39:17Z

src/main/java/org/lanternpowered/server/LanternServerLaunch.java

@@ -45,7 +45,7 @@

 public final class LanternServerLaunch {

-    public void main(String[] args) {
+    public static void main(String[] args) {


You can make this non-static again, the method is called from LanternLaunch. This isn't really the main method.

Ah, my run configuration was just set-up wrong then. Will do!

Cybermaxke · 2017-06-25T09:18:39Z

src/main/java/org/lanternpowered/server/entity/living/player/LanternPlayer.java

@@ -306,7 +306,8 @@ public void registerKeys() {
        registerKey(LanternKeys.MAX_FOOD_LEVEL, 20, 0, Integer.MAX_VALUE);
        registerKey(Keys.FOOD_LEVEL, 20, 0, LanternKeys.MAX_FOOD_LEVEL);
        registerKey(LanternKeys.MAX_SATURATION, 40.0, 0.0, Double.MAX_VALUE);
-        registerKey(Keys.SATURATION, 40.0, 0.0, LanternKeys.MAX_SATURATION);
+        registerKey(Keys.SATURATION, 5.0, 0.0, LanternKeys.MAX_SATURATION);
+        registerKey(Keys.EXHAUSTION, 0.0, 0.0, 40.0);


Maybe also a MAX_EXHAUSTION key?

Cybermaxke · 2017-06-25T09:19:26Z

src/main/java/org/lanternpowered/server/entity/LanternLiving.java

+     * @return If this entity can be healed
+     */
+    public boolean canBeHealed() {
+        return health().get() > health().getMinValue() && health().get() < health().getMaxValue();


Only call health() once and reuse the result.

Cybermaxke · 2017-06-25T09:19:36Z

src/main/java/org/lanternpowered/server/entity/LanternLiving.java

+     * @param amount The amount to heal for
+     */
+    public void heal(double amount) {
+        if (health().get() > health().getMinValue()) {


Only call health() once and reuse the result.

Cybermaxke · 2017-06-25T09:20:01Z

src/main/java/org/lanternpowered/server/entity/LanternLiving.java

+            }
+        } else if (foodLevel.get() <= foodLevel.getMinValue()) {
+            if ((System.currentTimeMillis() - this.lastFoodTime) >= 4000) {
+                if (health().get() > 10.0 || getWorld().getDifficulty().equals(Difficulties.HARD) || health().get() > 1.0 && difficulty.equals(


Only call health() once and reuse the result.

Cybermaxke · 2017-06-25T09:22:30Z

src/main/java/org/lanternpowered/server/entity/LanternLiving.java

+            }
+        }
+
+        final boolean naturalRegeneration = getWorld().getGameRule(DefaultGameRules.NATURAL_REGENERATION).orElse("true").equals("true");


Use the getRule method, this will automatically handle parsing. The rule can be found in RuleTypes.

Cybermaxke · 2017-06-25T10:11:54Z

src/main/java/org/lanternpowered/server/data/manipulator/DataManipulatorRegistry.java

                    c.registerKey(LanternKeys.MAX_FOOD_LEVEL, 20, 0, Integer.MAX_VALUE);
+                    c.registerKey(Keys.FOOD_LEVEL, 20, 0, LanternKeys.MAX_FOOD_LEVEL);
+                    c.registerKey(LanternKeys.MAX_EXHAUSTION, 40.0, 0.0, Double.MAX_VALUE);
                    c.registerKey(Keys.EXHAUSTION, 0.0, 0.0, 40.0);


The MAX_EXHAUSTION key shoul be used instead of the 40.0 as the max value.

Cybermaxke · 2017-06-25T10:32:30Z

src/main/java/org/lanternpowered/server/data/manipulator/DataManipulatorRegistry.java

+                    c.registerKey(Keys.FOOD_LEVEL, 20, 0, LanternKeys.MAX_FOOD_LEVEL);
+                    c.registerKey(LanternKeys.MAX_EXHAUSTION, 40.0, 0.0, Double.MAX_VALUE);
+                    c.registerKey(Keys.EXHAUSTION, 0.0, 0.0, LanternKeys.MAX_EXHAUSTION);
+                    c.registerKey(LanternKeys.MAX_SATURATION, 40.0, 0.0, Double.MAX_VALUE);


The default max saturation is 5.0

It seems that's the default saturation. I can't find a clear max, as it seems to actually change?

"The maximum value of the food saturation level is equal to the current value of your food level"

I'm not really sure how to handle this

So maximum 20 by default? You can also remove the MAX_SATURATION key and use FOOD as the maximum for SATURATION. I don't really know how the food system works.

parlough · 2017-06-25T22:22:34Z

So I think the other behaviors are out of scope of what I can accomplish now, at least the movement ones, as they are a bit over my head.

For the damage one, I am waiting on SpongePowered/SpongeAPI#1592

For now though, I think the functionality is pretty close. It seems peaceful regeneration of food looks strange, not sure how to go about fixing that though.

Cybermaxke · 2017-06-27T10:42:23Z

src/main/java/org/lanternpowered/server/block/behavior/simple/SimpleBreakBehavior.java

@@ -47,6 +48,11 @@ public BehaviorResult tryBreak(BehaviorPipeline<Behavior> pipeline, BehaviorCont
        builder.blockState(BlockTypes.AIR.getDefaultState());
        // Add the block change
        context.addBlockChange(builder.build());
+        context.get(Parameters.PLAYER).ifPresent(p -> {
+            if (p.supports(Keys.EXHAUSTION)) {
+                p.offer(Keys.EXHAUSTION, p.get(Keys.EXHAUSTION).get() + .005);


Can you replace the .005 with 0.005

Cybermaxke · 2017-06-29T09:06:31Z

src/main/java/org/lanternpowered/server/data/manipulator/DataManipulatorRegistry.java

-                    c.register(Keys.SATURATION, 0.0, 0.0, 5.0);
+                    c.register(Keys.FOOD_LEVEL, 20, 0, LanternKeys.MAX_FOOD_LEVEL);
+                    c.registerWithSuppliedMax(LanternKeys.MAX_SATURATION, 20.0, 0.0, container -> container.get(Keys.FOOD_LEVEL).get().doubleValue());
+                    c.register(Keys.SATURATION, 5.0, 0.0, LanternKeys.MAX_SATURATION);


Weren't you going to remove the MAX_SATURATION key and use the food level as max? Because now will the max saturation never change, well, it can only become smaller if the food level decreases.

parlough · 2017-06-30T09:44:39Z

I'll fix that build error when I solve the exhaustion issues.

parlough · 2017-06-30T20:51:49Z

So it seems everything is working including the hunger effect - I am successfully adding 0.005 x level per tick as the wiki for the 30 seconds to add up to 3 exhaustion which matches the description on the wiki here:

The remaining exhaustion effects, damages, and changes to consumables are probably out of the scope of this PR for now, so if you want any other changes just ask.

parlough · 2017-08-11T05:37:32Z

My PR about switching SaturationProperty to use the proper value was pulled into Sponge, so I will go ahead and update all of the current saturation values as well as where I manipulate them.

Cybermaxke · 2017-09-30T08:53:47Z

Development continues in #42

Cybermaxke reviewed Apr 27, 2017

View reviewed changes

parlough force-pushed the feature/health-data branch from 046eebe to a3e59a4 Compare June 25, 2017 06:51

parlough changed the title ~~[WIP] Begin work on food data and some health related ideas~~ Some food data work for players Jun 25, 2017

Cybermaxke reviewed Jun 25, 2017

View reviewed changes

Cybermaxke reviewed Jun 27, 2017

View reviewed changes

Cybermaxke added the type: gameplay feature label Jun 27, 2017

Cybermaxke self-assigned this Jun 27, 2017

parlough force-pushed the feature/health-data branch 2 times, most recently from b816e1f to eec7b6b Compare June 28, 2017 15:36

Cybermaxke reviewed Jun 29, 2017

View reviewed changes

parlough force-pushed the feature/health-data branch from 83020cb to 4d41b03 Compare June 30, 2017 07:06

Cybermaxke mentioned this pull request Jun 30, 2017

Death/damage/health/food system #20

Open

33 tasks

parlough force-pushed the feature/health-data branch from 4d41b03 to c874be6 Compare June 30, 2017 19:46

parlough force-pushed the feature/health-data branch 2 times, most recently from 2552297 to 3e6847a Compare July 2, 2017 22:11

Implement food data and processing

2f05793

parlough force-pushed the feature/health-data branch from 3e6847a to 2f05793 Compare July 3, 2017 21:35

Fix some values and modify original saturation values

7fb6de9

Cybermaxke mentioned this pull request Sep 30, 2017

Death/damage/health/food system #42

Closed

Cybermaxke closed this Sep 30, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Some food data work for players #5

Some food data work for players #5

parlough commented Apr 20, 2017 •

edited

Loading

Cybermaxke Apr 27, 2017

Cybermaxke Apr 27, 2017

Cybermaxke Apr 27, 2017 •

edited

Loading

parlough commented May 14, 2017

Cybermaxke Jun 25, 2017

parlough Jun 25, 2017

Cybermaxke Jun 25, 2017

Cybermaxke Jun 25, 2017

Cybermaxke Jun 25, 2017

Cybermaxke Jun 25, 2017

Cybermaxke Jun 25, 2017

Cybermaxke Jun 25, 2017

Cybermaxke Jun 25, 2017

parlough Jun 25, 2017

parlough Jun 25, 2017

Cybermaxke Jun 25, 2017

parlough commented Jun 25, 2017 •

edited

Loading

Cybermaxke Jun 27, 2017

Cybermaxke Jun 29, 2017

parlough commented Jun 30, 2017

parlough commented Jun 30, 2017 •

edited

Loading

parlough commented Aug 11, 2017

Cybermaxke commented Sep 30, 2017

Some food data work for players #5

Some food data work for players #5

Conversation

parlough commented Apr 20, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Cybermaxke Apr 27, 2017 • edited Loading

Choose a reason for hiding this comment

parlough commented May 14, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

parlough commented Jun 25, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

parlough commented Jun 30, 2017

parlough commented Jun 30, 2017 • edited Loading

parlough commented Aug 11, 2017

Cybermaxke commented Sep 30, 2017

parlough commented Apr 20, 2017 •

edited

Loading

Cybermaxke Apr 27, 2017 •

edited

Loading

parlough commented Jun 25, 2017 •

edited

Loading

parlough commented Jun 30, 2017 •

edited

Loading