[WIP] Change code to run with Python 3 #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* replace print with print() * replace unichr() with chr() * replace xrange with range() * fix the imports
also removed the content of __init__.py
|
Porting RecuperaBit to Python 3 might take any arbitrary amount of time, so I would say that it needs to be done properly regardless on when they plan to stop updating Python 2. I will take a look, however I do not commit to deadlines on FLOSS projects. 😅 |
|
Sure, no problem! Here I just wanted to facilitate the work by making sure the software globally runs with python3, but I realize the inner parts might take more time to get updated! At least now there is a basis for the porting :) |
NicolasCARPi
changed the title
I understand and this is much appreaciated, thank you for what you have done so far! |
Merged
|
Superseeded by #73 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
As discussed here, I made a python3 compatible version (see https://pythonclock.org/).
The code runs, I believe I changed all the necessary bits and pieces so it runs. BUT, and it's a big but, it seems it doesn't manage to recover partitions.
So please have a look at the code and try it out on real data and let me know if you find something. Because I'm not familiar with the codebase, I might have missed something.
~Nico