Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python3 Support #73

Merged
merged 2 commits into from
Jan 2, 2021
Merged

Python3 Support #73

merged 2 commits into from
Jan 2, 2021

Conversation

Maxqia
Copy link
Contributor

@Maxqia Maxqia commented Mar 9, 2020

This replaces #63.
Seems to be fully working, but it could do with more testing.

NicolasCARPi and others added 2 commits March 9, 2020 11:31
@NicolasCARPi @Maxqia
(try to) Make it work with python 3
dec2de6 
* replace print with print()
* replace unichr() with chr()
* replace xrange with range()
* fix the imports

also removed the content of __init__.py
@Maxqia
fully working on python3
4da2de8
@Lazza
Copy link
Owner

Lazza commented Jun 12, 2020

First of all, thank you for your very important contribution.

I just wanted to say "sorry" because I have not had the time to review it and I feel a bit guilty about it. This period has been (and still is) super busy with work and other personal stuff.

I really hope to be able to review it carefully. Please don't assume that your contribution is not appreciated...

@Lazza
Copy link
Owner

Lazza commented Jun 12, 2020

@NicolasCARPi I was wondering if maybe you would like to check this out as well.

@NicolasCARPi
Copy link
Contributor

@Lazza I think @Maxqia took my changes as a base and added more changes. I'll just close mine because this seems more "finished".

@NicolasCARPi NicolasCARPi mentioned this pull request Jun 12, 2020
Closed
Lazza
Lazza approved these changes Jan 2, 2021
View reviewed changes
Copy link
Owner

@Lazza Lazza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job

@Lazza
Copy link
Owner

Lazza commented Jan 2, 2021

@Maxqia thank you again for your contributions.

Please let me reiterate my apologies for the late feedback. You have done a very appreciated task of migrating this to Python 3. I will check out if some optimizations can be done, but for now it all seems to work.

@Lazza Lazza merged commit 022354d into Lazza:master Jan 2, 2021
@Lazza
Copy link
Owner

Lazza commented Jan 2, 2021

Also thanks to @NicolasCARPi and other contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lazza Lazza Lazza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Maxqia @Lazza @NicolasCARPi