Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "autocomplete" as initialization option #17159

Merged
merged 1 commit into from
Sep 14, 2018

Conversation

antoinelyset
Copy link
Contributor

Hi 👋 !

I have the same issue as #17155, but I suggest a slightly different modification. I don't know if this is a priority but I feared that by modifying the default "autocomplete" value we may break some users' usage (even if this is an undocumented behaviour). Moreover by defaulting to "off" we are still following the best practices.

What do you think ?

And one more question, do I need to update the built/generated files ?

@LeaVerou
Copy link
Owner

Hey, thanks for submitting a PR!

I wouldn't worry about breaking usage. There doesn't seem to be any use case for having both Awesomplete and the browser's autocomplete.
With this, people would need to specify the required value manually, when all they want is to disable the native autocomplete. This is against the UX best practice of sensible defaults.

@antoinelyset
Copy link
Contributor Author

I understand, should I still keep the possibility to pass another value as an option ?

@LeaVerou
Copy link
Owner

It seems a little premature to me. We can always add it very easily if even one person requests it, but having a feature with zero use cases seems excessive.
Hope that makes sense!

@antoinelyset
Copy link
Contributor Author

I completely understand (I wanted to set it to "new-address" for a more semantic name).
I made the change.

@LeaVerou LeaVerou merged commit 9896781 into LeaVerou:gh-pages Sep 14, 2018
@LeaVerou
Copy link
Owner

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants