Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting for NBGL on LNS, LNX and LNSP #123

Closed
wants to merge 10 commits into from
Closed

Conversation

xchapron-ledger
Copy link
Contributor

@xchapron-ledger xchapron-ledger commented Apr 26, 2024

May need (TBC):

  • update ragger scenario with something like this to dismiss the status message (/!\ need to find a BAGL and NBGL way of doing this):
diff --git a/src/ragger/navigator/navigation_scenario.py b/src/ragger/navigator/navigation_scenario.py
index f903e97..d9548bb 100644
--- a/src/ragger/navigator/navigation_scenario.py
+++ b/src/ragger/navigator/navigation_scenario.py
@@ -18,7 +18,7 @@ class NavigationScenarioData:
     def __init__(self, device: str, use_case: UseCase, approve: bool):
         if device.startswith("nano"):
             self.navigation = NavInsID.RIGHT_CLICK
-            self.validation = [NavInsID.BOTH_CLICK]
+            self.validation = [NavInsID.BOTH_CLICK, NavInsID.BOTH_CLICK]
             self.pattern = "^Approve$" if approve else "^Reject$"
 
         elif device.startswith("stax") or device.startswith("flex"):

Needs SDK adaptations, for the moment in branch LedgerHQ/ledger-secure-sdk#838

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.46%. Comparing base (9c2ea1c) to head (06728e4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #123   +/-   ##
=======================================
  Coverage   88.46%   88.46%           
=======================================
  Files           5        5           
  Lines          78       78           
  Branches       20       20           
=======================================
  Hits           69       69           
  Misses          9        9           
Flag Coverage Δ
unittests 88.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xchapron-ledger xchapron-ledger force-pushed the xch/nbgl-lns branch 2 times, most recently from 77d90a6 to a14545b Compare April 30, 2024 12:58
@xchapron-ledger xchapron-ledger changed the title Porting for NBGL on LNS Porting for NBGL on LNS, LNX and LNSP Apr 30, 2024
@xchapron-ledger
Copy link
Contributor Author

Unlocked by LedgerHQ/ledger-app-builder#151? 👀

@cedelavergne-ledger
Copy link
Contributor

Unlocked by LedgerHQ/ledger-app-builder#151? 👀

At least, it is the 1st step, hopefully now we have all the needing stuff to progress on this one.

If you have time and want to try to update it, do not hesitate 😜

@tdejoigny-ledger
Copy link
Contributor

@xchapron-ledger
Glad to see that you are still monitoring this subject. 😄
Indeed >> NBGL for all devices (except NanoS) targeted for Q1 2025

@cedelavergne-ledger cedelavergne-ledger force-pushed the xch/nbgl-lns branch 3 times, most recently from 55d4908 to 39a2ad1 Compare January 3, 2025 17:00
@cedelavergne-ledger
Copy link
Contributor

Branch renamed, because targeting LNX and LNSP and not LNS.
New PR is: #145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants