Add support for NBGL on LNS #70
Conversation
(cherry picked from commit 2b4d131)
(cherry picked from commit b106c7b)
(cherry picked from commit aaded6e)
…flag (cherry picked from commit e255f0f)
(cherry picked from commit cbe3ba5343d7ae0c64b8f80aa929acdf15dd1ae0)
(cherry picked from commit c951b1c0b8948e2c215fa79fa140d42c5a165329)
…ontentTagValueList_t nbgl_layoutTagValueList_t was already an alias of nbgl_contentTagValueList_t. Now with choose to use this directly. (cherry picked from commit 2e7edf5300c24e69a3a8a1e8eed37798ca85c521)
…EN_DISPLAY_RAW_STATUS
| // Consider the resulting text fit in screen | ||
| char buffer[SCREEN_LINE_MAX_STRING_LEN]; | ||
|
|
||
| #if 1 |
There was a problem hiding this comment.
Which option will we keep ?
There was a problem hiding this comment.
I'm considering exposing u8toa somewhere apps could use it too. Though this is useful only for LNS, sparing quite a lot of flash if the app code doesn't need snprintf...
What do you think about it?
|
|
||
| if (left) { | ||
| if (screen_content.vertical_nav) { | ||
| display_glyph(&C_icon_up, 2, 15, 7, 4); |
There was a problem hiding this comment.
Would be helpful to have defines, in order to follow easier the coce, and adapt if needed later?
xchapron-ledger
force-pushed
the
xch/nbgl-lns
branch
2 times, most recently
from
4bcc5c2
to
b204a92
Compare
xchapron-ledger
force-pushed
the
xch/nbgl-lns
branch
2 times, most recently
from
a7130d1
to
5efe86e
Compare
| uint8_t button_mask; | ||
| uint8_t button_same_mask_counter; | ||
|
|
||
| // enable speeded up long push (continuous) |
There was a problem hiding this comment.
Keeping the button pressed to review faster ?
Has it been validated by product or something ?
There was a problem hiding this comment.
This is there only because it's needed on LNX and LNSP and I kept the file really similar to the one in the ledger-secure-sdk branch.
Apps that only use the NBGL use case API won't use it. But some apps can still use it if they use the lower API.
| @@ -58,9 +58,7 @@ WEAK uint8_t io_event(uint8_t channel) | |||
|
|
|||
| switch (G_io_seproxyhal_spi_buffer[0]) { | |||
| case SEPROXYHAL_TAG_BUTTON_PUSH_EVENT: | |||
| #ifdef HAVE_BAGL | |||
| UX_BUTTON_PUSH_EVENT(G_io_seproxyhal_spi_buffer); | |||
There was a problem hiding this comment.
i would have expected us to use the ! HAVE_BAGL in the standard app
I'm probably missing something 🤔
There was a problem hiding this comment.
I simplified to only support the LNS case which events are handled the same if we use BAGL or NBGL.
It's a divergence with the version in ledger-secure-sdk master branch, but to keep it compatible, I would have to add so many #ifdef TARGET_NANOS that it won't be better IMO.
xchapron-ledger
force-pushed
the
xch/nbgl-lns
branch
from
5efe86e
to
89c8da1
Compare
|
Replaced by LedgerHQ/ledger-secure-sdk#651 |
Demo available here: LedgerHQ/app-boilerplate#123