Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Soroban support. #81

Closed
wants to merge 6 commits into from
Closed

Conversation

overcat
Copy link
Contributor

@overcat overcat commented Feb 19, 2024

This PR has been moved to #84

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2024

Codecov Report

Attention: Patch coverage is 82.51232% with 71 lines in your changes are missing coverage. Please review.

Project coverage is 77.72%. Comparing base (4a4b1cd) to head (16f70ce).

Files Patch % Lines
src/transaction/transaction_parser.c 80.35% 56 Missing ⚠️
src/transaction/transaction_formatter.c 91.50% 9 Missing ⚠️
src/swap/handle_check_address.c 0.00% 3 Missing ⚠️
src/utils.c 75.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #81      +/-   ##
===========================================
+ Coverage    76.87%   77.72%   +0.85%     
===========================================
  Files           14       14              
  Lines         2378     2779     +401     
===========================================
+ Hits          1828     2160     +332     
- Misses         550      619      +69     
Flag Coverage Δ
unittests 77.72% <82.51%> (+0.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sieg-i
Copy link

sieg-i commented Apr 23, 2024

Really looking forward to see Soroban supported by the Ledger app!

@overcat
Copy link
Contributor Author

overcat commented Apr 23, 2024

Due to my plan to submit a new PR with a lot of updates recently, in order to save resources, let's close this PR first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants