This repository has been archived by the owner on Jul 15, 2022. It is now read-only.
LL-8982 Add error for 0 qty ERC1155 NFT send #1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/ledgerhq/ledger-live-common/8MV1yJMFXyhyvGEheebnhTYQaBvz |
4 tasks
gre
reviewed
Jan 28, 2022
| @@ -14,6 +14,9 @@ import { prepareTransaction } from "./erc721"; | |||
| const notOwnedNft = createCustomErrorClass("NotOwnedNft"); | |||
| const notEnoughNftOwned = createCustomErrorClass("NotEnoughNftOwned"); | |||
| const notTokenIdsProvided = createCustomErrorClass("NotTokenIdsProvided"); | |||
| const quantityNeedsToBePositive = createCustomErrorClass( | |||
There was a problem hiding this comment.
errors need to start with uppercase (indeed it's also a mistake for all other vars)
There was a problem hiding this comment.
to be taken into consideration later
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context (issues, jira)
LL-8982
Description / Usage
The user won't be able to use '0' for quantity when sending an ERC1155 NFT
Expectations
To be tested by QA