Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

LL-8982 Add message for NFT 0 qty error #4682

Merged
merged 2 commits into from
Jan 31, 2022
Merged

LL-8982 Add message for NFT 0 qty error #4682

merged 2 commits into from
Jan 31, 2022

Conversation

grsoares21
Copy link
Contributor

@grsoares21 grsoares21 commented Jan 26, 2022

🦒 Context (issues, jira)

LL-8982

💻 Description / Demo (image or video)

Adds the translated message for the error that is added by LedgerHQ/ledger-live-common#1659

image

🖤 Expectations to reach

PR must pass CI, merge develop if conflicts, do not force push. Thanks!

  • on QA: at least one of these two checkboxes must be checked:
    • a specific test planned is defined on Jira
    • this PR is covered by automatic UI test
  • on delivery: at least one of these two checkboxes must be checked:
    • Option 1: no impact: The changes of this PR have ZERO impact on the userland (invisible for users)
    • Option 2: atomic delivery: the changes is atomic and complete (no partial delivery)

PR must pass CI, merge develop if conflicts, do not force push. Thanks!

@grsoares21 grsoares21 requested a review from a team as a code owner January 26, 2022 16:21
@github-actions
Copy link

github-actions bot commented Jan 26, 2022

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 8.74% 9/103
🔴 Branches 0% 0/19
🔴 Functions 2.94% 1/34
🔴 Lines 8.33% 8/96

Test suite run success

1 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from ad49d98

Copy link
Contributor

@elbywan elbywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏁

@gre gre merged commit b0b1238 into develop Jan 31, 2022
@gre gre deleted the LL-8982 branch January 31, 2022 10:29
Copy link
Contributor

@ychen-ledger ychen-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated with MacOS - LLD 2.37.2-sha.29b65e1de712e4a91bfababea83ef41516181132

valpinkman added a commit that referenced this pull request Feb 9, 2022
* releases/2.38.x: (55 commits)
  v2.38.2
  (LL-MKT): remove 1h graph range and mini graph color while we sort out the data (#4712)
  LIVE-881 - Fix window not opening for users who have "dusk" theme (#4711)
  v2.38.1
  LL-8791 LL-9146 (Market): release (#4667)
  v2.38.0
  ledger-live-common 21.32.0 (#4696)
  More padding bottom
  Add padding bottom
  Remove developer CTA in platform catalog
  LL-9044 Change plugin rendering on Manager
  LL-9023 Remove bold from token-id in nft viewer (#4693)
  LL-9028 Handle new lastSeenDevice event on DeviceActions (#4659)
  LL-9176 Add trackers for the NFT feature (#4694)
  design fix
  swap: display parent accounts in the target account drawer
  [LL-8097] sell/fund flow (#4361)
  LL-7480: swap wording for the exchange drawer (#4377)
  LL-8982 Add message for NFT 0 qty error (#4682)
  chore(publish): use the s3 publisher & provider for nightlies (#4685)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants