This repository has been archived by the owner on Jun 16, 2022. It is now read-only.
LIVE-881 - Fix window not opening for users who have "dusk" theme #4711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qd-qd
approved these changes
Feb 3, 2022
thomasrogerlux
approved these changes
Feb 3, 2022
valpinkman
added a commit
that referenced
this pull request
Feb 9, 2022
* releases/2.38.x: (55 commits) v2.38.2 (LL-MKT): remove 1h graph range and mini graph color while we sort out the data (#4712) LIVE-881 - Fix window not opening for users who have "dusk" theme (#4711) v2.38.1 LL-8791 LL-9146 (Market): release (#4667) v2.38.0 ledger-live-common 21.32.0 (#4696) More padding bottom Add padding bottom Remove developer CTA in platform catalog LL-9044 Change plugin rendering on Manager LL-9023 Remove bold from token-id in nft viewer (#4693) LL-9028 Handle new lastSeenDevice event on DeviceActions (#4659) LL-9176 Add trackers for the NFT feature (#4694) design fix swap: display parent accounts in the target account drawer [LL-8097] sell/fund flow (#4361) LL-7480: swap wording for the exchange drawer (#4377) LL-8982 Add message for NFT 0 qty error (#4682) chore(publish): use the s3 publisher & provider for nightlies (#4685) ...
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦒 Context (issues, jira)
LIVE-881
App is not starting when the theme was "dusk" (app is actually starting but the window is never created).
💻 Description / Demo (image or video)
A "valid" value for
settings.themeis now either"dark"or"light"as we removed the"dusk"theme (cf1e8f1).3 fixes:
src/main/window-lifecycle.js, make sure to not set thethemequery parameter as an invalid value.preloader/index.jsadding a fallback logic (to the dark theme) in the preloader that uses that query param.🖤 Expectations to reach
PR must pass CI, merge develop if conflicts, do not force push. Thanks!
PR must pass CI, merge develop if conflicts, do not force push. Thanks!