Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

chore(publish): use the s3 publisher & provider for nightlies #4685

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

elbywan
Copy link
Contributor

@elbywan elbywan commented Jan 27, 2022

🦒 Context (issues, jira)

Use the S3 provider / publisher for nightlies.

@valpinkman

💻 Description / Demo (image or video)

🖤 Expectations to reach

PR must pass CI, merge develop if conflicts, do not force push. Thanks!

  • on QA: at least one of these two checkboxes must be checked:
    • a specific test planned is defined on Jira
    • this PR is covered by automatic UI test
  • on delivery: at least one of these two checkboxes must be checked:
    • Option 1: no impact: The changes of this PR have ZERO impact on the userland (invisible for users)
    • Option 2: atomic delivery: the changes is atomic and complete (no partial delivery)

PR must pass CI, merge develop if conflicts, do not force push. Thanks!

@elbywan elbywan requested a review from a team as a code owner January 27, 2022 16:43
@elbywan elbywan requested a review from valpinkman January 27, 2022 16:43
@github-actions
Copy link

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 8.74% 9/103
🔴 Branches 0% 0/19
🔴 Functions 2.94% 1/34
🔴 Lines 8.33% 8/96

Test suite run success

1 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 9d9409b

@valpinkman valpinkman merged commit 7a15c4a into develop Jan 27, 2022
@valpinkman valpinkman deleted the nightly-s3-releases branch January 27, 2022 17:33
valpinkman added a commit that referenced this pull request Feb 9, 2022
* releases/2.38.x: (55 commits)
  v2.38.2
  (LL-MKT): remove 1h graph range and mini graph color while we sort out the data (#4712)
  LIVE-881 - Fix window not opening for users who have "dusk" theme (#4711)
  v2.38.1
  LL-8791 LL-9146 (Market): release (#4667)
  v2.38.0
  ledger-live-common 21.32.0 (#4696)
  More padding bottom
  Add padding bottom
  Remove developer CTA in platform catalog
  LL-9044 Change plugin rendering on Manager
  LL-9023 Remove bold from token-id in nft viewer (#4693)
  LL-9028 Handle new lastSeenDevice event on DeviceActions (#4659)
  LL-9176 Add trackers for the NFT feature (#4694)
  design fix
  swap: display parent accounts in the target account drawer
  [LL-8097] sell/fund flow (#4361)
  LL-7480: swap wording for the exchange drawer (#4377)
  LL-8982 Add message for NFT 0 qty error (#4682)
  chore(publish): use the s3 publisher & provider for nightlies (#4685)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants