Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

Bump ledgerhq deps #4653

Closed
wants to merge 2 commits into from
Closed

Bump ledgerhq deps #4653

wants to merge 2 commits into from

Conversation

chabroA
Copy link
Contributor

@chabroA chabroA commented Jan 18, 2022

🦒 Context (issues, jira)

Update following deps:

  • @ledgerhq/hw-transport-node-hid-singleton: "6.20.0" -> "6.23.0"
  • @ledgerhq/live-common: "^21.26.1" -> "^21.27.0"

💻 Description / Demo (image or video)

🖤 Expectations to reach

PR must pass CI, merge develop if conflicts, do not force push. Thanks!

  • on QA: at least one of these two checkboxes must be checked:
    • a specific test planned is defined on Jira
    • this PR is covered by automatic UI test
  • on delivery: at least one of these two checkboxes must be checked:
    • Option 1: no impact: The changes of this PR have ZERO impact on the userland (invisible for users)
    • Option 2: atomic delivery: the changes is atomic and complete (no partial delivery)

PR must pass CI, merge develop if conflicts, do not force push. Thanks!

@chabroA chabroA requested review from a team as code owners January 18, 2022 13:33
@github-actions
Copy link

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 8.74% 9/103
🔴 Branches 0% 0/19
🔴 Functions 2.94% 1/34
🔴 Lines 8.33% 8/96

Test suite run success

1 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from c8c8541

@chabroA chabroA mentioned this pull request Jan 18, 2022
5 tasks
@juan-cortes
Copy link
Contributor

This includes the work from #4647 which is currently in QA by @alalmi-ledger so merging this should be done only after it's qa ok over there.

Closes #4647

@juan-cortes
Copy link
Contributor

QA seem to have found some issues with a specific device, we need more investigation on the cause

@juan-cortes
Copy link
Contributor

Reverting the changes on the singleton transport until we figure out what's causing the erratic connection QA found. Can't afford introducing a bug like this that would impact many users. So, we need LedgerHQ/ledgerjs#770 merged, ledgerjs released with that, and to use the new version here again.

Or in the meantime, drop the singleton library bump if you need the rest.

"@ledgerhq/ledger-core": "6.14.5",
"@ledgerhq/live-common": "^21.26.1",
"@ledgerhq/live-common": "^21.27.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA KO makes this not possible

@chabroA
Copy link
Contributor Author

chabroA commented Jan 20, 2022

Reverting the changes on the singleton transport until we figure out what's causing the erratic connection QA found. Can't afford introducing a bug like this that would impact many users. So, we need LedgerHQ/ledgerjs#770 merged, ledgerjs released with that, and to use the new version here again.

Or in the meantime, drop the singleton library bump if you need the rest.

@juan-cortes Ok so if I understand correctly we can bump @ledgerhq/live-common: "^21.26.1" -> "^21.27.0" but not @ledgerhq/hw-transport-node-hid-singleton?
If that the case, that's fine by me 👌

@chabroA
Copy link
Contributor Author

chabroA commented Jan 20, 2022

Duplicated by #4664

@chabroA chabroA closed this Jan 20, 2022
@chabroA chabroA deleted the bump-ledgerhq-deps branch January 20, 2022 13:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants