-
Notifications
You must be signed in to change notification settings - Fork 299
Conversation
Coverage report
Test suite run success1 tests passing in 1 suite.Report generated by 🧪jest coverage report action from c8c8541 |
This includes the work from #4647 which is currently in QA by @alalmi-ledger so merging this should be done only after it's qa ok over there. Closes #4647 |
QA seem to have found some issues with a specific device, we need more investigation on the cause |
Reverting the changes on the singleton transport until we figure out what's causing the erratic connection QA found. Can't afford introducing a bug like this that would impact many users. So, we need LedgerHQ/ledgerjs#770 merged, ledgerjs released with that, and to use the new version here again. Or in the meantime, drop the singleton library bump if you need the rest. |
"@ledgerhq/ledger-core": "6.14.5", | ||
"@ledgerhq/live-common": "^21.26.1", | ||
"@ledgerhq/live-common": "^21.27.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA KO makes this not possible
@juan-cortes Ok so if I understand correctly we can bump |
Duplicated by #4664 |
🦒 Context (issues, jira)
Update following deps:
@ledgerhq/hw-transport-node-hid-singleton
:"6.20.0"
->"6.23.0"
@ledgerhq/live-common
:"^21.26.1"
->"^21.27.0"
💻 Description / Demo (image or video)
🖤 Expectations to reach
PR must pass CI, merge develop if conflicts, do not force push. Thanks!
PR must pass CI, merge develop if conflicts, do not force push. Thanks!