Skip to content
This repository has been archived by the owner on Jun 27, 2022. It is now read-only.

Revert "LL-8941 Automatically release USB connection after 5s" #770

Merged
merged 2 commits into from
Jan 20, 2022
Merged

Conversation

juan-cortes
Copy link
Contributor

This reverts commit ee60579.

QA founds some issues on https://ledgerhq.atlassian.net/browse/LL-8941 and we can't block package upgrades, this reverts the changes on the singleton transport until we figure out a more stable solution.

@juan-cortes juan-cortes requested a review from a team as a code owner January 19, 2022 14:07
@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #770 (abcb224) into master (aa41abf) will increase coverage by 0.12%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #770      +/-   ##
==========================================
+ Coverage   43.39%   43.51%   +0.12%     
==========================================
  Files          81       81              
  Lines        4897     4883      -14     
  Branches      860      859       -1     
==========================================
  Hits         2125     2125              
+ Misses       2758     2744      -14     
  Partials       14       14              
Impacted Files Coverage Δ
...ansport-node-hid-singleton/src/TransportNodeHid.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa41abf...abcb224. Read the comment docs.

Copy link
Contributor

@gre gre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
CI / docs (pull_request) Failing after 1m — docs

@juan-cortes juan-cortes requested a review from gre January 20, 2022 10:13
@gre gre merged commit 19292dc into master Jan 20, 2022
@gre gre deleted the LL-8941_2 branch January 20, 2022 10:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants