bugfix(Layout): Layout issue with the error message if Bluetooth is disabled when user pairs device #1307
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 93d7603 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -11,6 +11,8 @@ const SafeAreaContainer = styled.SafeAreaView` | |||
| align-items: center; | |||
| justify-content: center; | |||
| background-color: ${p => p.theme.colors.background.main}; | |||
| margin-left: 24px; | |||
There was a problem hiding this comment.
Can you the theme spacing values ?
Ex : margin-left: ${p => p.theme.space[2]}px;
| @@ -24,13 +26,13 @@ function BluetoothDisabled() { | |||
| return ( | |||
| <SafeAreaContainer> | |||
| <IconBox Icon={BluetoothMedium} iconSize={24} boxSize={64} /> | |||
| <Text variant={"h2"} mb={5} mt={7}> | |||
| <Text variant={"h2"} mb={5} mt={7} textAlign="center"> | |||
There was a problem hiding this comment.
If you want to improve this, you have a component from the ui drawer that have the exact same layout (icon box, title, description)
It's ModalHeader
Screenshots: ✅
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
…isabled when user pairs device
mcayuelas-ledger
force-pushed
the
bugfix/llm-pair-device-flow
branch
from
ca5d852 to
93d7603
Compare
Codecov ReportBase: 0.00% // Head: 43.64% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1307 +/- ##
============================================
+ Coverage 0 43.64% +43.64%
============================================
Files 0 610 +610
Lines 0 25544 +25544
Branches 0 6972 +6972
============================================
+ Hits 0 11149 +11149
- Misses 0 14346 +14346
- Partials 0 49 +49
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…isabled when user pairs device (#1307) * bugfix(Layout): Layout issue with the error message if Bluetooth is disabled when user pairs device * 🤓 Review
📝 Description
Layout issue with the error message if Bluetooth is disabled when user pairs device
❓ Context
live-mobile✅ Checklist
📸 Demo
Before
After
🚀 Expectations to reach
Disable bluetooth > Go to Pair device flow
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.