Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(Layout): Layout issue with the error message if Bluetooth is disabled when user pairs device #1307

Merged
merged 2 commits into from
Oct 4, 2022
Merged

bugfix(Layout): Layout issue with the error message if Bluetooth is disabled when user pairs device #1307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0490c1b
bugfix(Layout): Layout issue with the error message if Bluetooth is d…
mcayuelas-ledger Sep 19, 2022
93d7603
🤓 Review
mcayuelas-ledger Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/quick-moles-fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"live-mobile": patch
---

Layout issue with the error message if Bluetooth is disabled when user pairs device
6 changes: 4 additions & 2 deletions apps/ledger-live-mobile/src/components/RequiresBLE/BluetoothDisabled.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ const SafeAreaContainer = styled.SafeAreaView`
align-items: center;
justify-content: center;
background-color: ${p => p.theme.colors.background.main};
margin-left: ${p => `${p.theme.space[4]}px`};
margin-right: ${p => `${p.theme.space[4]}px`};
`;

function BluetoothDisabled() {
Expand All @@ -24,13 +26,13 @@ function BluetoothDisabled() {
return (
<SafeAreaContainer>
<IconBox Icon={BluetoothMedium} iconSize={24} boxSize={64} />
<Text variant={"h2"} mb={5} mt={7}>
<Text variant={"h2"} mb={5} mt={7} textAlign="center">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to improve this, you have a component from the ui drawer that have the exact same layout (icon box, title, description)
It's ModalHeader

<Trans i18nKey="bluetooth.required" />
</Text>
<Text
variant={"body"}
fontWeight={"medium"}
textAlign={"justify"}
textAlign="center"
color={"neutral.c80"}
>
<Trans i18nKey="bluetooth.checkEnabled" values={deviceNames.nanoX} />
Expand Down