Sentry: add more env context on errors #386

gre · 2022-06-17T10:20:01Z

📝 Description

On Sentry, we currently don't know if any experimental OR feature flag has been enabled in context of an error, which is very valuable to know about.

Trade-off: this works with "polling". The current implementation will regularly sync the tags so they are always correct when an error arise.

This PR only do this on LLM as the LLD PR isn't merged there, but we'll eventually also apply the same idea to LLD.

❓ Context

Impacted projects: LLM and LLD

✅ Checklist

Test coverage: this is not automatically tested. I have manually tested on Mac and Android. This is the reference documentation to test: https://github.com/LedgerHQ/ledger-live/wiki/Manually-Test-Sentry-integration
Atomic delivery
No breaking changes

📸 Demo

We can see the env and the feature flags

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

vercel · 2022-06-17T10:20:04Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
live-common-tools	✅ Ready (Inspect)	Visit Preview	Jul 5, 2022 at 3:34PM (UTC)

3 Ignored Deployments

Name	Status	Updated
ledger-live-github-bot	⬜️ Ignored (Inspect)	Jul 5, 2022 at 3:34PM (UTC)
native-ui-storybook	⬜️ Ignored (Inspect)	Jul 5, 2022 at 3:34PM (UTC)
react-ui-storybook	⬜️ Ignored (Inspect)	Jul 5, 2022 at 3:34PM (UTC)

changeset-bot · 2022-06-17T10:20:05Z

🦋 Changeset detected

Latest commit: 9062bdc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
ledger-live-desktop	Patch
live-mobile	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2022-06-17T10:42:37Z

@gre

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

codecov · 2022-07-04T15:37:19Z

Codecov Report

Merging #386 (9062bdc) into develop (cf80564) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #386   +/-   ##
========================================
  Coverage    47.98%   47.98%           
========================================
  Files          607      607           
  Lines        26954    26954           
  Branches      6897     6897           
========================================
  Hits         12935    12935           
  Misses       13959    13959           
  Partials        60       60

Flag	Coverage Δ
test	`47.98% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf80564...9062bdc. Read the comment docs.

apps/ledger-live-desktop/release-notes.json

ofreyssinet-ledger

lgtm 👍

elbywan · 2022-07-07T12:14:38Z

apps/ledger-live-desktop/src/renderer/components/ConnectEnvsToSentry.tsx

+    // We need to wait firebase to load the data and then we set once for all the tags
+    setTimeout(syncTheTags, 5000);
+    // We also try to regularly update them so we are sure to get the correct tags (as these are dynamic)
+    setInterval(syncTheTags, 60000);


I understand that this component is high up the tree, and will likely not re-render often but if for some reason it does we really need to return a cleanup function that will clear the interval (and the timeout, even though it's less critical).

elbywan · 2022-07-07T12:16:14Z

apps/ledger-live-mobile/index.js

@@ -24,11 +24,14 @@ import * as Sentry from "@sentry/react-native";
 import Config from "react-native-config";
 import VersionNumber from "react-native-version-number";

+import { getEnv } from "@ledgerhq/live-common/lib/env";


since the common module is now transpiled to esm it would be better to not rely on the commonjs bundle @ledgerhq/live-common/lib/env => @ledgerhq/live-common/env

github-actions bot added the mobile Has changes in LLM label Jun 17, 2022

github-actions bot assigned gre Jun 17, 2022

vercel bot deployed to Preview – live-common-tools June 17, 2022 10:21 View deployment

gre force-pushed the support/sentry-extra-tags branch from 562f369 to 3b2a936 Compare June 20, 2022 16:58

github-actions bot added the desktop Has changes in LLD label Jun 20, 2022

vercel bot deployed to Preview – live-common-tools June 20, 2022 17:00 View deployment

gre force-pushed the support/sentry-extra-tags branch from 3b2a936 to e03eea9 Compare June 20, 2022 17:08

vercel bot deployed to Preview – live-common-tools June 20, 2022 17:09 View deployment

gre changed the title ~~LLM Sentry: add more env context on errors~~ Sentry: add more env context on errors Jun 24, 2022

gre force-pushed the support/sentry-extra-tags branch from e03eea9 to 28cc23a Compare July 4, 2022 15:20

vercel bot deployed to Preview – live-common-tools July 4, 2022 15:21 View deployment

gre force-pushed the support/sentry-extra-tags branch from 28cc23a to ff48eae Compare July 4, 2022 17:05

vercel bot deployed to Preview – live-common-tools July 4, 2022 17:06 View deployment

gre marked this pull request as ready for review July 4, 2022 17:15

gre commented Jul 4, 2022

View reviewed changes

apps/ledger-live-desktop/release-notes.json Outdated Show resolved Hide resolved

gre force-pushed the support/sentry-extra-tags branch from ff48eae to dbee373 Compare July 5, 2022 09:07

vercel bot deployed to Preview – live-common-tools July 5, 2022 09:08 View deployment

gre force-pushed the support/sentry-extra-tags branch from dbee373 to 3c03cc8 Compare July 5, 2022 12:12

vercel bot deployed to Preview – live-common-tools July 5, 2022 12:15 View deployment

gre force-pushed the support/sentry-extra-tags branch from 3c03cc8 to d4e56f2 Compare July 5, 2022 12:36

vercel bot deployed to Preview – live-common-tools July 5, 2022 12:37 View deployment

gre force-pushed the support/sentry-extra-tags branch from d4e56f2 to c6fa222 Compare July 5, 2022 13:00

vercel bot deployed to Preview – live-common-tools July 5, 2022 13:01 View deployment

gre mentioned this pull request Jul 5, 2022

LLM: update Sentry + split config per platform #575

Merged

4 tasks

vercel bot deployed to Preview – live-common-tools July 5, 2022 13:41 View deployment

vercel bot deployed to Preview – react-ui-storybook July 5, 2022 13:43 View deployment

vercel bot deployed to Preview – native-ui-storybook July 5, 2022 13:43 View deployment

gre force-pushed the support/sentry-extra-tags branch from 14fb036 to bc86070 Compare July 5, 2022 15:16

vercel bot deployed to Preview – live-common-tools July 5, 2022 15:16 View deployment

gre force-pushed the support/sentry-extra-tags branch from bc86070 to 74196c4 Compare July 5, 2022 15:26

vercel bot deployed to Preview – live-common-tools July 5, 2022 15:27 View deployment

Attach feature flags and envs to Sentry reports

9062bdc

gre force-pushed the support/sentry-extra-tags branch from 74196c4 to 9062bdc Compare July 5, 2022 15:33

vercel bot deployed to Preview – live-common-tools July 5, 2022 15:34 View deployment

gre requested a review from a team July 7, 2022 08:03

ofreyssinet-ledger approved these changes Jul 7, 2022

View reviewed changes

gre merged commit 8917ca1 into develop Jul 7, 2022

gre deleted the support/sentry-extra-tags branch July 7, 2022 14:57

elbywan reviewed Jul 7, 2022

View reviewed changes

gre added a commit that referenced this pull request Jul 7, 2022

Polishes from merged PR #386 feedbacks

75f9e78

gre mentioned this pull request Jul 7, 2022

Polishes from merged PR #386 feedbacks #605

Merged

3 tasks

gre added a commit that referenced this pull request Jul 7, 2022

Polishes from merged PR #386 feedbacks (#605)

a87936f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sentry: add more env context on errors #386

Sentry: add more env context on errors #386

gre commented Jun 17, 2022 •

edited

Loading

vercel bot commented Jun 17, 2022 •

edited

Loading

changeset-bot bot commented Jun 17, 2022 •

edited

Loading

github-actions bot commented Jun 17, 2022 •

edited

Loading

codecov bot commented Jul 4, 2022 •

edited

Loading

ofreyssinet-ledger left a comment

elbywan Jul 7, 2022 •

edited

Loading

elbywan Jul 7, 2022

elbywan Jul 7, 2022

Sentry: add more env context on errors #386

Sentry: add more env context on errors #386

Conversation

gre commented Jun 17, 2022 • edited Loading

📝 Description

❓ Context

✅ Checklist

📸 Demo

🚀 Expectations to reach

vercel bot commented Jun 17, 2022 • edited Loading

changeset-bot bot commented Jun 17, 2022 • edited Loading

🦋 Changeset detected

github-actions bot commented Jun 17, 2022 • edited Loading

codecov bot commented Jul 4, 2022 • edited Loading

Codecov Report

ofreyssinet-ledger left a comment

Choose a reason for hiding this comment

elbywan Jul 7, 2022 • edited Loading

Choose a reason for hiding this comment

elbywan Jul 7, 2022

Choose a reason for hiding this comment

elbywan Jul 7, 2022

Choose a reason for hiding this comment

gre commented Jun 17, 2022 •

edited

Loading

vercel bot commented Jun 17, 2022 •

edited

Loading

changeset-bot bot commented Jun 17, 2022 •

edited

Loading

github-actions bot commented Jun 17, 2022 •

edited

Loading

codecov bot commented Jul 4, 2022 •

edited

Loading

elbywan Jul 7, 2022 •

edited

Loading