Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polishes from merged PR #386 feedbacks #605

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

gre
Copy link
Contributor

@gre gre commented Jul 7, 2022

📝 Description

Polishes from merged PR #386 feedbacks

❓ Context

  • Impacted projects: LLD, LLM

✅ Checklist

  • Test coverage should be good by CI compilation
  • Atomic delivery
  • No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Jul 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Jul 7, 2022 at 3:07PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Jul 7, 2022 at 3:07PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Jul 7, 2022 at 3:07PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Jul 7, 2022 at 3:07PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Jul 7, 2022

⚠️ No Changeset found

Latest commit: 75f9e78

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@elbywan elbywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙇

@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #605 (6ba1c97) into develop (8917ca1) will not change coverage.
The diff coverage is n/a.

❗ Current head 6ba1c97 differs from pull request most recent head 75f9e78. Consider uploading reports for the commit 75f9e78 to get more accurate results

@@           Coverage Diff            @@
##           develop     #605   +/-   ##
========================================
  Coverage    47.65%   47.65%           
========================================
  Files          613      613           
  Lines        27258    27258           
  Branches      6977     6977           
========================================
  Hits         12990    12990           
  Misses       14208    14208           
  Partials        60       60           
Flag Coverage Δ
test 47.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8917ca1...75f9e78. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jul 7, 2022

@gre

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@gre gre merged commit a87936f into develop Jul 7, 2022
@gre gre deleted the support/sentry-extra-tags-oopsy branch July 7, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants