[FIX]: Fix displayed text in confirm recovery phrase during onboarding Nano #6121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Ignored Deployments
|
cgrellard-ledger
approved these changes
Feb 8, 2024
sshmaxime
approved these changes
Feb 8, 2024
kallen-ledger
pushed a commit
that referenced
this pull request
Feb 9, 2024
jdabbech-ledger
pushed a commit
that referenced
this pull request
Feb 19, 2024
jdabbech-ledger
pushed a commit
that referenced
this pull request
Feb 19, 2024
jdabbech-ledger
added a commit
that referenced
this pull request
Feb 23, 2024
* style: add scrollview to evm staking drawer * chore: update copy in common json * feat: style scrollbar, update translations, add stader figment icons * chore: remove support links * fix: rm button on mobile drawer, rm fading edge * chore: rm scroll offset * refactor: add fallback if an icon cannot be found * Setup ABTesting feature flag for the portfolio carousel * Feat-live 10403 btc doc (#6050) * btc doc * btc doc * btc doc * btc doc * btc doc * btc doc * add changeset * btc doc * fix: update btc doc * fix: update btc doc * Remove old Carousel in LLD * fix: remove playwright replay on macOS and Windows * [FEAT] : simpleHash usage for NFTs Gallery in LL (#6029) * Draft simpleHash usage * Remove spread * commit pnpm * Reorg hook 🪝 * Fixed Types * Fix loading and type issue * remove fake color * WIP * Improvment * test: add useNftGalleryFilter test * Add FF * Fix unimported in lib * [FEAT]: use simpleHash for LLD Gallery (#6042) * Add changeset * chore: move the api endpoint into its env * Review * Try new SPAM_FILTER_THRESHOLD * FIX e2E tests * fix test --------- Co-authored-by: Gaëtan Renaudeau <renaudeau.gaetan@gmail.com> * Add Action Card * Update braze types + update braze hook + add usePortfolioCards hooks * Add Variant A and B on Portfolio Carousel * Rename LlmAnalyticsOptInPromptVariants to ABTestingVariants on LLM * Add onView on ContentCard + add VariantB and VariantA functionnality for Portfolio ContentCards * Avoid displaying Content Cards when there is no content cards * Add Card wrapper around Carousel VariantA + remove custom checks when click on card * Disable braze when running Playwright accross LLD * feat: better error message when user reject tx on swap * fix(lld): fixed sidebare active items for market currency and assets pages * Unify design for Recover and Action cards + remove footer when only 1 card in Carousel * chore: added changeset * fix(lld): fixed sidebare active items for market currency and assets pages * fix(deps): update dependency @dfinity/agent to v0.21.4 (#6095) * fix(deps): update dependency @dfinity/agent to v0.21.4 * fix: bot --------- Co-authored-by: live-github-bot[bot] <105061298+live-github-bot[bot]@users.noreply.github.com> Co-authored-by: Gaëtan Renaudeau <renaudeau.gaetan@gmail.com> * support: fix RemoteLiveAppProvider not updating if env changes * Remove win32 and darwin screenshots (#6102) fix: remove win32 and darwin screenshots * wip * working prototype * wip * remove useless dep * wip * global setup/teardown usage * remove useless edits * remove useless file * ci test * add another workflow instead * rename * random diff * update pnpm lock * fix commands * filter rework * ripple support * fix nock mocking * more specific cleaning * rework mock apply * remove bad import * remove useless filter * add comms * remove useless comment * types * reduce file size, add types * fix linter * nock => devDeps * add osmosis, stargaze support * stargaze * comments * remove filter * remove useless deletes and var * run only on ubuntu * trigger on algorand * fix ci * remove algorand diff * add changeset * fix(LLM): wallet connect deep link handling * chore: add TODO comment * chore: add changeset * fix(LLM/ParentAccountError): Fixed copy for parent account error * refactor: small improvement * feat: clarify error message for invalid address selected * feat: clarify error message for invalid address selected * feat(LIVE-9363): add semi colomn * fix: exclude ethereum classic from accounts with stake button * chore: changeset * [CAL] Support Linea Tokens (#6057) * update cal tokens * update snapshots * refactor: use strict equals eth account * chore: Turn off Allure Reports Export on Server CI jobs (#6106) Includes 2 readme type fixes to test the workflows * fix: only open EVM staking modal if the user receives ethereum * refactor: rm duplicate type, show tag only if has min required eth, * chore: add generic requires min json to avoid future duplicated translations * fix: eth providers type * support: stop generating mac and windows screenshots with the generate-screenshots github action * fix(lld): fixed accounts order after changing countervalue in the settings * fix(lld): fixed accounts order after changing countervalue in the settings * test(lld): update screenshots (ubuntu-latest) lld, test, screenshot * fix(llm): center text on solana and atom modals * [LIVE-10787] Bugfix: Add missing dependencies for Eth clones & plugins (#6114) * Add missing dependencies for ETH clones/plugins * changeset * fix(deps): update dependency @dfinity/candid to v0.21.4 (#6104) Co-authored-by: live-github-bot[bot] <105061298+live-github-bot[bot]@users.noreply.github.com> * feat: add translation on discover timestamps * feat: replace datefns package and trnaslation * feat: change type + improvements * feat: correct type * feat: correct types * feat: fix type * feat: fix type * feat: fix type * [FIX]: Fix displayed text in confirm recovery phrase during onboarding Nano (#6121) * fix: type * chore(lld): remove unused zxcvbn lib (#6122) * fix: type * support: refactor fetching manifest (#6123) * support: refactor fetching manifest * chore: fix lint * support(llm): removed recommendations toggle from the notifications settings * [LIVE-1108][LLD][COMMON][ERRORS] Handle LockedDeviceError correctly (#6107) * fix(error): fix device locked error instance Signed-off-by: jdabbech-ledger <jalil.dabbech@ledger.com> * fix(lld): display correctly the error in update fw modal Signed-off-by: jdabbech-ledger <jalil.dabbech@ledger.com> --------- Signed-off-by: jdabbech-ledger <jalil.dabbech@ledger.com> * [Feat/LIVE10991]: send swapApiBase to swap-live-app (#6071) * feat: pass SWAP_API_BASE into swap-live-app * chore: add changeset * [coin-config] Make getValueBykey backward compatible (#6053) * backward compatible getValueByKey * import from lodash/merge * feat: new Market arch * chore(lodash): all lodash imports must use the fp import style (#6125) chore(lodash): all lodash imports must use the fp import style + eslint rules * fix: AccountRow navigation * feat: deliver behind feature flag new market * fix: load feature flag from live-common * fix: improve const naming and our reselect usage * fix: getFeature as a prop for LLD * [BUGFIX] : Continue button was greyed out in step 1 of Send flow if the Account to debit is changed (#6139) * fix: use FF suffix for feature flag * refactor(common/listappsv2): create use case in "device/" * refactor(common/listappsv2): remove direct usages of getEnv * refactor(common/device): move listApps entrypoint to listAppsUsecase * [LIVE-5605] Support - EVM Documentation (#5682) * Add full documentation to coin-evm package * Move signer to types folder * Move clear signed selectors to evm-tools lib * Remove unused env * Remove usage of `ledgerService` to make `hw-app-eth` a devDep * Lint imports * Update `NotEnoughBalance` error for token transactions * changeset * Adding this non-sensical list of unresolved imports for a non-sensical library. * fix(LIVE-11204): fix min and max amount error when using moonpay * refactor(common): add TODO, rename variables * test(common/listApps/v2): test basic error cases test(common/listApps/v2): more error cases * refactor(ManagerApiRepository): add getAppsByHash * refactor(ManagerApiRepository): implement StubManagerApiRepository * refactor(listAppsV2): use managerApiRepository * refactor(ManagerApiRepository): catalogForDevice, getLanguagePackagesForDevice * test(getLatestFirmwareForDevice): replace mocks by stub api repository * test(listAppsV2): cleanup * refactor(mocks): move entities mocks to device-core * chore: changeset chore: changeset * refactor(StubManagerApiRepository): replace mocks * chore: cleanup * fix: lint & bad import fix: imports fix: lint & bad import fix(llm): bad import * refactor(common/getProviderIdUseCase): add a default value to PROVIDERS fix(getProviderIdUseCase): revert breaking change to an enum * [B2CQA-658] Detox : Improve Manager tests (#6063) test: check device informations and apps * fix(HttpManagerApiRepository): badly infered types for makeLRUCache fix(HttpManagerApiRepository): missing type + reword comment * refactor(listAppsV1): pass managerApiRepository argument * fix: btc doc update * fix: btc doc update * test: add change currency test * fix: btc doc update * test: add favorites test * fix: update btc doc * fix: update btc doc * fix: update btc doc * fix: update btc doc * fix: update btc doc * fix lint * fix(LIVE-11143): fix useless renders and render issues swap live app * fix(LIVE-11143): wrong liveapp props given to state update * fix(LIVE-11143): remove logs in console * fix(LIVE-11143): remove useless component * fix(LIVE-11143): import fix * fix(LIVE-11143): Replace state by ref * Fix XLM crash when swapping (Demo 0) (#6127) * bugfix: cant-swap-XLM * chore: added changeset * Update .changeset/serious-goats-dream.md Co-authored-by: Quentin Jaccarino <quentin.jaccarino@ledger.fr> --------- Co-authored-by: Quentin Jaccarino <quentin.jaccarino@ledger.fr> * Add ptx to hw-app-exchange as codeowner * feat: add providers enabled count to analytics identify for evm modal ab test * chore: add changeset * fix: add ethStakingProvidersEnabled to all extraProperties * fix: type check on providers list * [Bugfix/LIVE-11035]: Moonpay LLD - Signature Step Error msg (#6120) * fix: swap_ng was broken (used in moonpay context * fix: add moonpay terms of service * i18n - including some staking ones --------- Co-authored-by: ldg-smartling-sa <133769770+ldg-smartling-sa@users.noreply.github.com> * [SUPPORT]: Update Feature flag to handle threshold spam filter directly from FF (#6144) * [SUPPORT]: Update Feature flag to handle threshold spam filter directly from FF * add changelog * fix type * Update logic for filters more generic * [fix/LIVE-11122]: update quotes when timeout reaches 0 in swap. (#6118) * fix: update countdown and refresh rates code * chore: add changeset * fix: memoize providers and exchangeRates to stop unnecessary calls to analytics * chore: remove unimported files * chore: fix typing (#6155) * chore: fix typing luckily hex or base64 string stringified to hex does not change the string. * chore: more fix * chore: small fix * chore(prerelease) update cryptoassets * chore(prerelease): 🚀 entering prerelease mode * chore(prerelease): 🚀 release prerelease [LLD(2.77.0-next.0), LLM(3.40.0-next.0)] * Merge pull request #6175 from LedgerHQ/bugfix/LIVE-11270 fix: LLD wallet connect deep link handling for requests [LIVE-11270] * chore(prerelease): 🚀 release prerelease [LLD(2.77.0-next.1), LLM(3.40.0-next.0)] * fix(listAppsV2): `forceProvider` parameter required * Merge pull request #6176 from LedgerHQ/bugfix/LIVE-11270 fix: LLD wallet connect deep link handling for requests [LIVE-11270] * fix(listAppsUseCase): bad conditional branching + add missing param * chore(prerelease): 🚀 release prerelease [LLD(2.77.0-next.2), LLM(3.40.0-next.0)] * fix(HttpManagerApiRepository): error remapping similar to manager/api.ts * test(listAppsV2): fix missing param * test(listAppsUseCase): test conditional calling of v1 or v2 * test(HttpManagerApiRepository): basic tests for all methods * test(HttpManagerApiRepository): test for getLanguagePackagesForDevice * chore: changeset * fix(ParentAccountError): Copy update * fix: use global flags and updateIdentify func * chore: add changeset * refactor: rm global segment vars, add ptx attributes to extra properties * chore(prerelease): 🚀 release prerelease [LLD(2.77.0-next.3), LLM(3.40.0-next.0)] * chore(prerelease): 🚀 release prerelease [LLD(2.77.0-next.4), LLM(3.40.0-next.1)] * chore(prerelease): 🚀 release prerelease [LLD(2.77.0-next.5), LLM(3.40.0-next.2)] * Bugfix/countdown timer refresh swap form (#6178) * fix(LIVE-11267): regression on analytics refreshing every 1 sec * fix(LIVE-11267): add changeset * Revert "[fix/LIVE-11122]: update quotes when timeout reaches 0 in swap. (#6118)" This reverts commit 63099cc. * fix(LIVE-11267): remove useless files * fix: underline a tags in Alert messages * chore(prerelease): 🚀 release prerelease [LLD(2.77.0-next.6), LLM(3.40.0-next.2)] * chore(prerelease): 🚀 release prerelease [LLD(2.77.0-next.7), LLM(3.40.0-next.2)] * [LLD] Release notes 2.77.0 (#6216) chore: add release notes 2.77.0 * Smartling on-demand translation delivery from release (#6229) * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to ar-AE locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to zh-CN locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to fr-FR locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to de-DE locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to ja-JP locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to ko-KR locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to pt-BR locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to ru-RU locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to es-ES locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to tr-TR locale * chore(prerelease): 🚀 release prerelease [LLD(2.77.0-next.7), LLM(3.40.0-next.2)] * chore(release): 🚀 prepare release [skip ci] * chore(hotfix) 🚀 entering hotfix mode * hotfix(lld): useFeature from common * chore(hotfix): 🔥 hotfix prerelease [LLD(2.77.1-hotfix.0), LLM(3.40.0)] * chore(hotfix): 🔥 hotfix release [skip ci] * chore: update release note files with proper content * chore(hotfix) 🚀 entering hotfix mode * fix: fetch NEAR staking positions from node instead of kitwallet API * chore: add changeset * chore(hotfix): 🔥 hotfix prerelease [LLD(2.77.2-hotfix.0), LLM(3.40.1-hotfix.0)] * update release notes hotfix * lowercase identifier fixes * fix crash on token account frame * fix integration tests * update integration test snapshots * update sortByMarketcap snapshot and fix linter * add fixme * chore(hotfix): 🔥 hotfix prerelease [LLD(2.77.2-hotfix.1), LLM(3.40.1-hotfix.1)] * chore(hotfix): 🔥 hotfix release [skip ci] * remove duplicated code * chore: resolve develop conflict * chore: release merge conflict extrs files LLM new arch * chore: fix lockflie axios version --------- Signed-off-by: jdabbech-ledger <jalil.dabbech@ledger.com> Co-authored-by: Beth Swingler <beth.swingler-ext@ledger.fr> Co-authored-by: Maxime Aubanel <sshmaxime@gmail.com> Co-authored-by: ofreyssinet-ledger <91890529+ofreyssinet-ledger@users.noreply.github.com> Co-authored-by: hzheng-ledger <71653044+hzheng-ledger@users.noreply.github.com> Co-authored-by: KVNLS <kevin.leseigle@gmail.com> Co-authored-by: Martin CAYUELAS <112866305+mcayuelas-ledger@users.noreply.github.com> Co-authored-by: Gaëtan Renaudeau <renaudeau.gaetan@gmail.com> Co-authored-by: Thomas Brillard <thomas.brillard@ledger.fr> Co-authored-by: Come Grellard <come.grellard@ledger.fr> Co-authored-by: Kevin Le Seigle <31533861+KVNLS@users.noreply.github.com> Co-authored-by: live-github-bot[bot] <105061298+live-github-bot[bot]@users.noreply.github.com> Co-authored-by: Kant <quentin.jaccarino@ledger.fr> Co-authored-by: Hedi EDELBLOUTE <hedi.edelbloute@gmail.com> Co-authored-by: male-gal <maxence.le-gall@ledger.fr> Co-authored-by: Louis PAQUET <louis.paquet@ledger.fr> Co-authored-by: Maxence LE GALL <39890664+mle-gall@users.noreply.github.com> Co-authored-by: Landry Monga <lvndry@protonmail.com> Co-authored-by: Alexandrine Boissiere <108733454+aboissiere-ledger@users.noreply.github.com> Co-authored-by: 0xkvn <44363395+lambertkevin@users.noreply.github.com> Co-authored-by: RamyEB <ramyelb@gmail.com> Co-authored-by: jdabbech-ledger <145363160+jdabbech-ledger@users.noreply.github.com> Co-authored-by: Kieran Allen <132384348+kallen-ledger@users.noreply.github.com> Co-authored-by: Olivier Freyssinet <olivier.freyssinet@ledger.fr> Co-authored-by: Abdurrahman Sastim <106583189+abdurrahman-ledger@users.noreply.github.com> Co-authored-by: hzheng-ledger <huiqi.zheng@ledger.fr> Co-authored-by: ldg-smartling-sa <133769770+ldg-smartling-sa@users.noreply.github.com> Co-authored-by: Kieran Allen <kieran.allen@ledger.fr> Co-authored-by: jdabbech-ledger <jalil.dabbech@ledger.com> Co-authored-by: Desifly <desire.ndri@ledger.fr> Co-authored-by: JesseKuntz <jessekuntz96@gmail.com>
This was referenced Mar 6, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Fix displayed text in confirm recovery phrase during onboarding Nano
❓ Context
✅ Checklist
Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.
npx changesetwas attached.🧐 Checklist for the PR Reviewers