fix(llm): prevent debounce causing memo change miss #8652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
themooneer
reviewed
Dec 10, 2024
apps/ledger-live-mobile/src/newArch/features/MemoTag/hooks/useMemoTagInput.ts
Show resolved
Hide resolved
| @@ -341,7 +341,12 @@ export default function SendSelectRecipient({ navigation, route }: Props) { | |||
| testID="recipient-continue-button" | |||
| type="primary" | |||
| title={<Trans i18nKey="common.continue" />} | |||
| disabled={debouncedBridgePending || !!status.errors.recipient || !!memoTag?.error} | |||
| disabled={ | |||
There was a problem hiding this comment.
just for readability, we can extract this above :)
thesan
force-pushed
the
fix/llm-secure-memo-debounce
branch
from
14bb54a to
2b5bfd0
Compare
thesan
force-pushed
the
fix/llm-secure-memo-debounce
branch
from
2b5bfd0 to
edb43f5
Compare
3 tasks
themooneer
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Prevent debounce from causing the memo tag not being saved.
Here's 2 example with the debounce set to 1 second for clarity:
the problem:
Screen.Recording.2024-12-10.at.10.54.13.mov
this PR's solution:
Screen.Recording.2024-12-10.at.10.57.02.mov
❓ Context
🧐 Checklist for the PR Reviewers