Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(llm): release prevent debounce causing memo change miss #8657

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

thesan
Copy link
Contributor

@thesan thesan commented Dec 10, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

(Release PR for: #8652)

Prevent debounce from causing the memo tag not being saved.

Here's 2 example with the debounce set to 1 second for clarity:

the problem:

Screen.Recording.2024-12-10.at.10.54.13.mov
this PR's solution:
Screen.Recording.2024-12-10.at.10.57.02.mov

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@thesan thesan requested a review from a team as a code owner December 10, 2024 12:33
Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Dec 10, 2024 0:33am
native-ui-storybook ⬜️ Ignored (Inspect) Dec 10, 2024 0:33am
react-ui-storybook ⬜️ Ignored (Inspect) Dec 10, 2024 0:33am
web-tools ⬜️ Ignored (Inspect) Dec 10, 2024 0:33am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Dec 10, 2024
@thesan thesan merged commit 31764d0 into release Dec 10, 2024
41 checks passed
@thesan thesan deleted the fix/llm-secure-memo-debounce-release branch December 10, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants