Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RageMP doesn't passes the handle for DrawScaleformMovieFullscreen and others #91

Closed
TheOfficialDroid opened this issue Aug 31, 2022 · 0 comments
Labels
priority: p1 high A bug that might cause crashes or a highly needed feature status: completed The feature has been completed of the bug has been patched type: bug This is a bug
Milestone

Comments

@TheOfficialDroid
Copy link

BaseScaleform uses incorrect native parameters; Consider replacing with RAGE.Game.Graphics

RAGE.Game.Graphics.RequestScaleformMovie
RAGE.Game.Graphics.CallScaleformMovieMethod - Begin
RAGE.Game.Graphics.PopScaleformMovieFunctionVoid End (VOID)
RAGE.Game.Graphics.PopScaleformMovieFunction End (int)

For whatever reason, you're calling the draw function without a referenced handle returned from the Engine; Thus nothing will ever be drawn for anyone using this within RageMP (see below)

Invoker.Invoke(0x0DF606929C105BE1, 255, 255, 255, 255, 0)

void DrawScaleformMovieFullscreen(int scaleform, int red, int green, int blue, int alpha, int unk);
Thus should be Invoker.Invoke(0x0DF606929C105BE1, Handle, 255, 255, 255, 255, 0)

TheOfficialDroid added a commit to TheOfficialDroid/LemonUI that referenced this issue Aug 31, 2022
Corrected invalid native call for RageMP and changed native invoker calls to their respective class functions, for better reference to the RageMP wiki

LemonUIbyLemon#91
@justalemon justalemon added status: confirmed The bug has been tested and confirmed priority: p1 high A bug that might cause crashes or a highly needed feature type: bug This is a bug labels Oct 3, 2022
@justalemon justalemon added this to the 1.9 milestone Oct 3, 2022
@justalemon justalemon changed the title Scaleform RageMP RageMP doesn't passes the handle for DrawScaleformMovieFullscreen and others Oct 3, 2022
@justalemon justalemon added status: completed The feature has been completed of the bug has been patched and removed status: confirmed The bug has been tested and confirmed labels Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p1 high A bug that might cause crashes or a highly needed feature status: completed The feature has been completed of the bug has been patched type: bug This is a bug
Projects
None yet
Development

No branches or pull requests

2 participants