Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BaseScaleform.cs #92

Closed

Conversation

TheOfficialDroid
Copy link

Corrected invalid native call for RageMP and changed native invoker calls to their respective class functions, for better reference to the RageMP wiki

See #91

Corrected invalid native call for RageMP and changed native invoker calls to their respective class functions, for better reference to the RageMP wiki

LemonUIbyLemon#91
@justalemon
Copy link
Member

Any specific reason for changing the way that natives are called?

@justalemon justalemon added type: bug This is a bug status: acknowledged We are aware of the bug or feature request priority: p2 medium A bug that makes things unstable or a feature that has been requested for a while labels Aug 31, 2022
@TheOfficialDroid
Copy link
Author

TheOfficialDroid commented Aug 31, 2022

Any specific reason for changing the way that natives are called?

better reference to the RageMP wiki

Even if said wiki is marginally incomplete; Most people are directed towards it and very few have a clue how to use the invoker to begin with; Personal preference, if you'd prefer I can reverse them back to native invocation with the correct params.

@justalemon
Copy link
Member

You should not use dynamic, as you don't know the type of return object during compilation.

@TheOfficialDroid
Copy link
Author

You should not use dynamic, as you don't know the type of return object during compilation.

None of the changes implemented, use dynamic?

@justalemon
Copy link
Member

Superseded by 80da07b

@justalemon justalemon closed this Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 medium A bug that makes things unstable or a feature that has been requested for a while status: acknowledged We are aware of the bug or feature request type: bug This is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants