-
-
Notifications
You must be signed in to change notification settings - Fork 52
Add tests for concurrent delete/iteration #46
Conversation
It might be a good idea to do an audit of different *down libraries, though, and see if they're already passing or failing the tests. I believe the second test fails in MemDOWN for instance, unless I'm just not running the tests correctly:
|
/cc @calvinmetcalf who wrote the first test |
t.notOk(err, 'no error') | ||
iterator.next(function (err, key, value) { | ||
t.notOk(err, 'no error') | ||
t.equals(key, 'c') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be 'b' if they have a snapshot
a61f18a
to
21db440
Compare
Small fix pointed out by @calvinmetcalf - if you delete |
I'm rebasing this branch. |
These tests sussed out bugs in localstorage-down (No9/localstorage-down#61) and memdown (Level/memdown#20), so they may be useful to add to abstract-leveldown.
21db440
to
935c947
Compare
Superseded by #239. |
These tests sussed out bugs in localstorage-down
(No9/localstorage-down#61) and memdown
(Level/memdown#20), so they may be useful to add
to abstract-leveldown.