(#61) - fix concurrent batch del while iterating #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
force-pushed
the
race-condition
branch
2 times, most recently
from
8e77b4f to
8c9a0b3
Compare
nolanlawson
added a commit
that referenced
this pull request
Oct 15, 2014
The test fails before the fix, but succeeds after. Also added some other tests just as a nice-to-have.
|
Yeah okay, figured it out and found a failing test. Note to self: donate the failing test to abstract-leveldown and memdown. |
nolanlawson
force-pushed
the
race-condition
branch
from
8c9a0b3 to
f6e7426
Compare
nolanlawson
added a commit
that referenced
this pull request
Oct 15, 2014
The test fails before the fix, but succeeds after. Also added some other tests just as a nice-to-have.
nolanlawson
changed the title
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
^ this is the test that needs to be donated
There was a problem hiding this comment.
in other libraries they will have a snapshot and it will be b not c
nolanlawson
added a commit
to Level/abstract-leveldown
that referenced
this pull request
Oct 15, 2014
These tests sussed out bugs in localstorage-down (No9/localstorage-down#61) and memdown (Level/memdown#20), so they may be useful to add to abstract-leveldown.
The test fails before the fix, but succeeds after. Also added some other tests just as a nice-to-have.
nolanlawson
force-pushed
the
race-condition
branch
from
f6e7426 to
adde547
Compare
nolanlawson
added a commit
to Level/abstract-leveldown
that referenced
this pull request
Oct 15, 2014
These tests sussed out bugs in localstorage-down (No9/localstorage-down#61) and memdown (Level/memdown#20), so they may be useful to add to abstract-leveldown.
|
just check for undefined instead of |
|
👍 |
|
woot, thanks! |
nolanlawson
added a commit
to Level/abstract-leveldown
that referenced
this pull request
May 18, 2015
These tests sussed out bugs in localstorage-down (No9/localstorage-down#61) and memdown (Level/memdown#20), so they may be useful to add to abstract-leveldown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the localStorage-only failures in pouchdb/pouchdb#2846, I've been trying to figure out if there's a race condition in localstorage-down.
I noticed @calvinmetcalf's fix in memdown (Level/memdown@8a3c6a0), but after copying the test and the fix over, it doesn't seem to have an impact here. The test was already passing before. Added another test, but same story - it was already passing.