Release/v 1.3.0 #1298
Merged
Release/v 1.3.0 #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…worker on thread (#1216) ** Commit Highlights: ** * first round of refactoring runners.py, Runner base class for normal in-place launches, but based on the contents of passed-in specs, instantiates the relevant subclass * ThreadRunner uses comms.QCommThread, slightly modified, to launch its user function. corresponding unit test * removing now-redundant content from manager, trying to see if we can start a temporary, local Worker for handling work * use _Worker class to correctly index into W and wcomms. add initial option to libE_specs * add "threaded" tentative option to sim/gen_specs * fix ThreadRunner shutdown when that worker didn't launch a thread * adjust alloc_support to not use w - 1 indexing * add tentative gen_on_manager option, separate additional_worker_launch into function * move _WorkerIndexer into libensemble.utils, also use within PersistentSupport * manager also needs to send workflow_dir location to worker 0 * simply gen_workers parameter description for avail_worker_ids * filter for gen_workers within avail_worker_ids, if set and there are gen_workers. solution resembles zrw, like shuds predicted all along! * refactor give_sim_work_first for running on gen_workers if no points_to_evaluate. add test for mixed existing sample plus calling a gen * it turns out that values set by validators are still considered "unset". So for updating purposes for libE_specs, we want to exclude fields that are still set to their defaults * platform_specs sometimes seems to be at risk of disappearing when we convert LibeSpecs to dict, so lets save it and reinsert * add libE_specs["gen_workers"] option, adjust ensure_one_active_gen so multiple gen work orders aren't given out at once ** Major features: ** * runners.py refactored to more easily develop additional methods to submit/run user functions * User functions can be launched by workers on separate threads alternatively to calling in-place. * Generator can be launched on the Manager - various refactors to make this possible * gen_workers option to specify workers that should run generators only * Various bugfixes and refactors of allocation functions --------- Co-authored-by: shudson <shudson@anl.gov> Co-authored-by: Jeffrey Larson <jmlarson@anl.gov>
Formatting/sphinx spellcheck
Fixing issue with start/end crossrefs
…ch of testing dep versions
Bumps [pytest-cov](https://github.com/pytest-dev/pytest-cov) from 4.1.0 to 5.0.0. - [Changelog](https://github.com/pytest-dev/pytest-cov/blob/master/CHANGELOG.rst) - [Commits](pytest-dev/pytest-cov@v4.1.0...v5.0.0) --- updated-dependencies: - dependency-name: pytest-cov dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…st-cov-5.0.0 Bump pytest-cov from 4.1.0 to 5.0.0
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.19.0 to 1.20.0. - [Release notes](https://github.com/crate-ci/typos/releases) - [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md) - [Commits](crate-ci/typos@v1.19.0...v1.20.0) --- updated-dependencies: - dependency-name: crate-ci/typos dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [globus-compute-sdk](https://github.com/funcx-faas/funcx) from 2.15.0 to 2.17.0. - [Release notes](https://github.com/funcx-faas/funcx/releases) - [Changelog](https://github.com/funcx-faas/funcX/blob/main/docs/changelog.rst) - [Commits](globus/globus-compute@2.15.0...2.17.0) --- updated-dependencies: - dependency-name: globus-compute-sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…us-compute-sdk-2.17.0 Bump globus-compute-sdk from 2.15.0 to 2.17.0
…evelop/crate-ci/typos-1.20.0 Bump crate-ci/typos from 1.19.0 to 1.20.0
…into release/v_1.3.0
jlnav
approved these changes
May 1, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1298 +/- ##
==========================================
+ Coverage 72.61% 73.94% +1.32%
==========================================
Files 90 90
Lines 8151 8243 +92
Branches 1458 1464 +6
==========================================
+ Hits 5919 6095 +176
+ Misses 1996 1934 -62
+ Partials 236 214 -22 ☔ View full report in Codecov by Sentry. |
jmlarson1
reviewed
May 1, 2024
jmlarson1
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1268