You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
is it possible to remove the dependency to this extra library? I see that it is used only in one place, to get the encoding of an xml-document from the bom header, see com.lowagie.text.xml.simpleparser.SimpleXMLParser.parse(...)
The logic in UniversalDetector.detectCharsetFromBOM(...) is not so special and complex and is not prone to be changed in the future. I know that reusing sourcecode is good practice. But in this situation copying the code is acceptable in my opinion because of the advantages of fewer dependencies and lesser efforts in maintaining an extra library and so on.
See also this merge-request: #124 where @andreasrosdal asked in the same direction...
Cheers,
Michael
The text was updated successfully, but these errors were encountered:
Dear all,
is it possible to remove the dependency to this extra library? I see that it is used only in one place, to get the encoding of an xml-document from the bom header, see com.lowagie.text.xml.simpleparser.SimpleXMLParser.parse(...)
The logic in UniversalDetector.detectCharsetFromBOM(...) is not so special and complex and is not prone to be changed in the future. I know that reusing sourcecode is good practice. But in this situation copying the code is acceptable in my opinion because of the advantages of fewer dependencies and lesser efforts in maintaining an extra library and so on.
See also this merge-request: #124 where @andreasrosdal asked in the same direction...
Cheers,
Michael
The text was updated successfully, but these errors were encountered: