Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency to juniversalchardet or make it an optional dependency #400

Closed
mwgmnn opened this issue Aug 21, 2020 · 1 comment
Closed

Comments

@mwgmnn
Copy link

mwgmnn commented Aug 21, 2020

Dear all,

is it possible to remove the dependency to this extra library? I see that it is used only in one place, to get the encoding of an xml-document from the bom header, see com.lowagie.text.xml.simpleparser.SimpleXMLParser.parse(...)
The logic in UniversalDetector.detectCharsetFromBOM(...) is not so special and complex and is not prone to be changed in the future. I know that reusing sourcecode is good practice. But in this situation copying the code is acceptable in my opinion because of the advantages of fewer dependencies and lesser efforts in maintaining an extra library and so on.

See also this merge-request: #124 where @andreasrosdal asked in the same direction...

Cheers,
Michael

lapo-luchini added a commit to lapo-luchini/OpenPDF that referenced this issue Aug 26, 2020
asturio pushed a commit that referenced this issue Aug 28, 2020
Drops dependency.
Closes GitHub issue #400.
@asturio
Copy link
Member

asturio commented Sep 9, 2020

This should be fixed now.

@asturio asturio closed this as completed Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants